From: Pedro Alves <palves@redhat.com>
To: Gary Benson <gbenson@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 3/5] Introduce common/gdb_setjmp.h
Date: Wed, 20 Aug 2014 16:54:00 -0000 [thread overview]
Message-ID: <53F4D2AB.6080706@redhat.com> (raw)
In-Reply-To: <1408351618-21013-4-git-send-email-gbenson@redhat.com>
On 08/18/2014 09:46 AM, Gary Benson wrote:
> This commit creates a new file, common/gdb_setjmp.h, to hold some
> portability macros for setjmp/longjmp et al. that are used by the
> exceptions subsystem and by the demangler crash catcher.
Looks like this one stands on its own.
OK, with ...
>
> gdb/
> 2014-08-18 Gary Benson <gbenson@redhat.com>
>
> * common/gdb_setjmp.h: New file.
> * Makefile.in (HFILES_NO_SRCDIR): Add common/gdb_setjmp.h.
> * configure.ac: Move sigsetjmp check...
> * common/common.m4: ...here.
> * configure: Regenerate.
> * cp-support.c (SIGJMP_BUF): Undefine.
... please say "Delete.". "Undefine" makes the reader expect
an #undef.
> (SIGSETJMP): Likewise.
> (SIGLONGJMP): Likewise.
> * exceptions.h (gdb_setjmp.h): Include.
> (setjmp.h): Do not include.
> (EXCEPTIONS_SIGJMP_BUF): Undefine.
Likewise.
> (EXCEPTIONS_SIGSETJMP): Likewise.
> (EXCEPTIONS_SIGLONGJMP): Likewise.
> Replace all uses of EXCEPTIONS_SIG* macros with SIG* macros
> from gdb_setjmp.h.
> * exceptions.c: Likewise.
>
> gdb/gdbserver/
> 2014-08-18 Gary Benson <gbenson@redhat.com>
>
> * config.in: Regenerate.
> * configure: Likewise.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2014-08-20 16:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-18 8:47 [PATCH 0/5] Make gdbserver use exceptions and cleanups Gary Benson
2014-08-18 8:47 ` [PATCH 3/5] Introduce common/gdb_setjmp.h Gary Benson
2014-08-20 16:54 ` Pedro Alves [this message]
2014-08-18 8:47 ` [PATCH 1/5] Move internal_{,v}warning to common/errors.[ch] Gary Benson
2014-08-18 8:47 ` [PATCH 2/5] Move cleanups.[ch] to common Gary Benson
2014-08-20 16:47 ` Pedro Alves
2014-08-20 19:05 ` Gary Benson
2014-08-28 15:35 ` Pedro Alves
2014-08-28 15:36 ` Pedro Alves
2014-08-18 8:52 ` [PATCH 4/5] Introduce common/common-exceptions.[ch] Gary Benson
2014-08-18 9:25 ` [PATCH 5/5] Use exceptions and cleanups in gdbserver Gary Benson
2014-08-28 15:35 ` Pedro Alves
2014-08-28 15:39 ` [PATCH 0/5] Make gdbserver use exceptions and cleanups Pedro Alves
2014-08-29 10:07 ` Gary Benson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F4D2AB.6080706@redhat.com \
--to=palves@redhat.com \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox