From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30706 invoked by alias); 20 Aug 2014 16:54:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30686 invoked by uid 89); 20 Aug 2014 16:54:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 20 Aug 2014 16:54:07 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7KGs56L016853 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 20 Aug 2014 12:54:06 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7KGs3Xe016348; Wed, 20 Aug 2014 12:54:04 -0400 Message-ID: <53F4D2AB.6080706@redhat.com> Date: Wed, 20 Aug 2014 16:54:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Gary Benson , gdb-patches@sourceware.org Subject: Re: [PATCH 3/5] Introduce common/gdb_setjmp.h References: <1408351618-21013-1-git-send-email-gbenson@redhat.com> <1408351618-21013-4-git-send-email-gbenson@redhat.com> In-Reply-To: <1408351618-21013-4-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-08/txt/msg00421.txt.bz2 On 08/18/2014 09:46 AM, Gary Benson wrote: > This commit creates a new file, common/gdb_setjmp.h, to hold some > portability macros for setjmp/longjmp et al. that are used by the > exceptions subsystem and by the demangler crash catcher. Looks like this one stands on its own. OK, with ... > > gdb/ > 2014-08-18 Gary Benson > > * common/gdb_setjmp.h: New file. > * Makefile.in (HFILES_NO_SRCDIR): Add common/gdb_setjmp.h. > * configure.ac: Move sigsetjmp check... > * common/common.m4: ...here. > * configure: Regenerate. > * cp-support.c (SIGJMP_BUF): Undefine. ... please say "Delete.". "Undefine" makes the reader expect an #undef. > (SIGSETJMP): Likewise. > (SIGLONGJMP): Likewise. > * exceptions.h (gdb_setjmp.h): Include. > (setjmp.h): Do not include. > (EXCEPTIONS_SIGJMP_BUF): Undefine. Likewise. > (EXCEPTIONS_SIGSETJMP): Likewise. > (EXCEPTIONS_SIGLONGJMP): Likewise. > Replace all uses of EXCEPTIONS_SIG* macros with SIG* macros > from gdb_setjmp.h. > * exceptions.c: Likewise. > > gdb/gdbserver/ > 2014-08-18 Gary Benson > > * config.in: Regenerate. > * configure: Likewise. Thanks, Pedro Alves