Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Gary Benson <gbenson@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/5] Move cleanups.[ch] to common
Date: Thu, 28 Aug 2014 15:36:00 -0000	[thread overview]
Message-ID: <53FF4C8A.1020103@redhat.com> (raw)
In-Reply-To: <1408351618-21013-3-git-send-email-gbenson@redhat.com>

Hi Gary,

On 08/18/2014 09:46 AM, Gary Benson wrote:
> gdb/
> 2014-08-18  Gary Benson  <gbenson@redhat.com>
> 
> 	* cleanups.h: Moved to...
> 	* common/cleanups.h: New file.
> 	* cleanups.c: Moved to...
> 	* common/cleanups.c: New file.

> --- a/gdb/cleanups.c
> +++ b/gdb/common/cleanups.c
> @@ -17,7 +17,8 @@
>     You should have received a copy of the GNU General Public License
>     along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
>
> -#include "defs.h"
> +#include "common-defs.h"
> +#include "cleanups.h"

The new cleanups.h inclusion should be mentioned in the ChangeLog as well.

> 	* Makefile.in (SFILES): Replace cleanups.c with common/cleanups.c.
> 	(HFILES_NO_SRCDIR): Replace cleanups.h with common/cleanups.h.
> 	(cleanups.o): New rule.

Thanks,
Pedro Alves


  parent reply	other threads:[~2014-08-28 15:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-18  8:47 [PATCH 0/5] Make gdbserver use exceptions and cleanups Gary Benson
2014-08-18  8:47 ` [PATCH 3/5] Introduce common/gdb_setjmp.h Gary Benson
2014-08-20 16:54   ` Pedro Alves
2014-08-18  8:47 ` [PATCH 2/5] Move cleanups.[ch] to common Gary Benson
2014-08-20 16:47   ` Pedro Alves
2014-08-20 19:05     ` Gary Benson
2014-08-28 15:35   ` Pedro Alves
2014-08-28 15:36   ` Pedro Alves [this message]
2014-08-18  8:47 ` [PATCH 1/5] Move internal_{,v}warning to common/errors.[ch] Gary Benson
2014-08-18  8:52 ` [PATCH 4/5] Introduce common/common-exceptions.[ch] Gary Benson
2014-08-18  9:25 ` [PATCH 5/5] Use exceptions and cleanups in gdbserver Gary Benson
2014-08-28 15:35   ` Pedro Alves
2014-08-28 15:39 ` [PATCH 0/5] Make gdbserver use exceptions and cleanups Pedro Alves
2014-08-29 10:07   ` Gary Benson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53FF4C8A.1020103@redhat.com \
    --to=palves@redhat.com \
    --cc=gbenson@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox