Re: [PATCH 0/5] Make gdbserver use exceptions and cleanups

[Gary Benson <gbenson@redhat.com>]

Pedro Alves wrote:
> On 08/18/2014 09:46 AM, Gary Benson wrote:
> > gdbserver has the rudiments of an exception system, but it's
> > kind of hacky.  This series converts gdbserver to use the
> > same exceptions and cleanups as GDB.
> > 
> > This series is fairly minimal in that only the catch/cleanup code
> > in what was "main" has been updated to use the new system.  Other
> > parts of gdbserver could likely be converted to TRY_CATCH and
> > cleanups too, but that can be done on an as-needed basis if this
> > patch is accepted.
> > 
> > A side-effect of this patch is that some error messages will
> > change slightly, and in cases with multiple errors the error
> > messages will be printed in a different order.
> > 
> > Built and regtested on RHEL 6.5 x86_64.
> > 
> > Ok to commit?
> 
> Other than the minor nits I just picked in the responses to the
> patches, this looks great to me.
> 
> Thanks a lot for doing this.

No problem, thanks for the review :)

I've pushed this with the changes you suggested.

common-exceptions.h and cleanups.h are now included in server.h.
They're not global includes in GDB, but I could put together a
patch making them so if you like?  Let me know...

Thanks,
Gary

-- 
http://gbenson.net/