From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13907 invoked by alias); 29 Aug 2014 10:07:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13894 invoked by uid 89); 29 Aug 2014 10:07:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 29 Aug 2014 10:07:13 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7TA7CuB030062 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 29 Aug 2014 06:07:12 -0400 Received: from blade.nx (ovpn-116-113.ams2.redhat.com [10.36.116.113]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7TA7BMu019184; Fri, 29 Aug 2014 06:07:11 -0400 Received: by blade.nx (Postfix, from userid 1000) id ABE322640D8; Fri, 29 Aug 2014 11:07:10 +0100 (BST) Date: Fri, 29 Aug 2014 10:07:00 -0000 From: Gary Benson To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/5] Make gdbserver use exceptions and cleanups Message-ID: <20140829100710.GA29302@blade.nx> References: <1408351618-21013-1-git-send-email-gbenson@redhat.com> <53FF4D37.4080704@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53FF4D37.4080704@redhat.com> X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00635.txt.bz2 Pedro Alves wrote: > On 08/18/2014 09:46 AM, Gary Benson wrote: > > gdbserver has the rudiments of an exception system, but it's > > kind of hacky. This series converts gdbserver to use the > > same exceptions and cleanups as GDB. > > > > This series is fairly minimal in that only the catch/cleanup code > > in what was "main" has been updated to use the new system. Other > > parts of gdbserver could likely be converted to TRY_CATCH and > > cleanups too, but that can be done on an as-needed basis if this > > patch is accepted. > > > > A side-effect of this patch is that some error messages will > > change slightly, and in cases with multiple errors the error > > messages will be printed in a different order. > > > > Built and regtested on RHEL 6.5 x86_64. > > > > Ok to commit? > > Other than the minor nits I just picked in the responses to the > patches, this looks great to me. > > Thanks a lot for doing this. No problem, thanks for the review :) I've pushed this with the changes you suggested. common-exceptions.h and cleanups.h are now included in server.h. They're not global includes in GDB, but I could put together a patch making them so if you like? Let me know... Thanks, Gary -- http://gbenson.net/