From: Yao Qi <yao@codesourcery.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [ping] [PATCH] Different outputs affected by locale
Date: Wed, 04 Jun 2014 13:21:00 -0000 [thread overview]
Message-ID: <538F1CC3.9090605@codesourcery.com> (raw)
In-Reply-To: <20140604124708.GR4289@adacore.com>
On 06/04/2014 08:47 PM, Joel Brobecker wrote:
>>> 2014-05-27 Yao Qi <yao@codesourcery.com>
>>>
>>> * gdb.base/wchar.exp: Execute command 'p repeat[1]' and extract
>>> cent from the output.
>
> This is a patch that I felt would be better reviewed by Tom, but
> we'd have to wait for him to be back. When I read your patch,
> I thought that the approach you took was weakening the test a little,
> because if GDB started printing the character incorrectly, you would
> not notice it anymore.
>
The character printed by GDB in this case is out the control of GDB,
IMO. IOW, we can't tell what character printed is correct and what is
incorrect. Or we can relax the pattern to match either \242 or '¢'
(cent sign) in the test. WDYT?
--
Yao (é½å°§)
next prev parent reply other threads:[~2014-06-04 13:21 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 12:13 Yao Qi
2014-06-04 5:32 ` [ping] " Yao Qi
2014-06-04 12:47 ` Joel Brobecker
2014-06-04 13:21 ` Yao Qi [this message]
2014-06-04 13:52 ` Joel Brobecker
2014-06-04 20:15 ` Tom Tromey
2014-06-04 20:23 ` Pedro Alves
2014-06-05 3:31 ` Yao Qi
2014-06-05 8:58 ` Pedro Alves
2014-06-05 9:58 ` Yao Qi
2014-06-05 10:12 ` Pedro Alves
2014-06-05 15:04 ` Eli Zaretskii
2014-06-09 8:37 ` Yao Qi
2014-06-09 10:11 ` Pedro Alves
2014-06-11 2:22 ` Yao Qi
2014-06-11 16:23 ` Eli Zaretskii
2014-06-12 0:48 ` Yao Qi
2014-06-12 2:47 ` Eli Zaretskii
2014-06-12 7:04 ` Yao Qi
2014-06-12 17:03 ` Eli Zaretskii
2014-06-17 1:03 ` Yao Qi
2014-06-12 11:36 ` Pedro Alves
2014-06-12 14:39 ` Yao Qi
2014-06-12 17:07 ` Eli Zaretskii
2014-06-12 17:23 ` Pedro Alves
2014-06-12 17:48 ` Eli Zaretskii
2014-06-17 3:46 ` Yao Qi
2014-06-17 10:03 ` Pedro Alves
2014-06-17 11:39 ` Yao Qi
2014-06-12 17:09 ` Eli Zaretskii
2014-06-12 17:27 ` Pedro Alves
2014-06-12 17:50 ` Eli Zaretskii
2014-06-12 18:06 ` Pedro Alves
2014-06-12 18:35 ` Eli Zaretskii
2014-06-16 13:58 ` Pedro Alves
2014-06-16 15:40 ` Eli Zaretskii
2014-06-16 16:23 ` Pedro Alves
2014-06-05 10:27 ` Pedro Alves
2014-06-05 14:47 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538F1CC3.9090605@codesourcery.com \
--to=yao@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox