From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8876 invoked by alias); 4 Jun 2014 13:21:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8863 invoked by uid 89); 4 Jun 2014 13:21:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Jun 2014 13:21:03 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1WsB7j-0004oY-Us from Yao_Qi@mentor.com ; Wed, 04 Jun 2014 06:20:59 -0700 Received: from SVR-ORW-FEM-06.mgc.mentorg.com ([147.34.97.120]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Wed, 4 Jun 2014 06:20:59 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by SVR-ORW-FEM-06.mgc.mentorg.com (147.34.97.120) with Microsoft SMTP Server id 14.2.247.3; Wed, 4 Jun 2014 06:20:59 -0700 Message-ID: <538F1CC3.9090605@codesourcery.com> Date: Wed, 04 Jun 2014 13:21:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Joel Brobecker CC: Subject: Re: [ping] [PATCH] Different outputs affected by locale References: <1401192650-29688-1-git-send-email-yao@codesourcery.com> <538EAEE5.2080708@codesourcery.com> <20140604124708.GR4289@adacore.com> In-Reply-To: <20140604124708.GR4289@adacore.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00157.txt.bz2 On 06/04/2014 08:47 PM, Joel Brobecker wrote: >>> 2014-05-27 Yao Qi >>> >>> * gdb.base/wchar.exp: Execute command 'p repeat[1]' and extract >>> cent from the output. > > This is a patch that I felt would be better reviewed by Tom, but > we'd have to wait for him to be back. When I read your patch, > I thought that the approach you took was weakening the test a little, > because if GDB started printing the character incorrectly, you would > not notice it anymore. > The character printed by GDB in this case is out the control of GDB, IMO. IOW, we can't tell what character printed is correct and what is incorrect. Or we can relax the pattern to match either \242 or '¢' (cent sign) in the test. WDYT? -- Yao (齐尧)