From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: Tom Tromey <tromey@redhat.com>,
Joel Brobecker <brobecker@adacore.com>,
gdb-patches@sourceware.org
Subject: Re: [ping] [PATCH] Different outputs affected by locale
Date: Thu, 12 Jun 2014 11:36:00 -0000 [thread overview]
Message-ID: <539990BD.9020504@redhat.com> (raw)
In-Reply-To: <5397BCEC.8080300@codesourcery.com>
On 06/11/2014 03:20 AM, Yao Qi wrote:
> On 06/09/2014 06:11 PM, Pedro Alves wrote:
>> I think the test caught a real GDB bug on Windows, and we
>> should fix GDB to make it look at the environment variables,
>> as is expected of GNU programs. And that the best way
>> to handle this is to import the gnulib setlocale module.
>
> I've started setlocale module import, but during the work, I did some
> experiments and the result is confusing me.
>
> We import setlocale so that we can set locale through env var, assuming
> that different locales affect the return value of iswprint (0xa2).
> However, this assumption isn't true on Windows :(
Well, it actually is.
>
> I write the following program to check the return value of iswprint
> under different locales.
>
> On Linux, the output is reasonable
> $ ./iswprint
> 4
> C: 0
> en_US.UTF-8: 1
> C: 0
>
> On Windows, iswprint always return true!
> C:\>iswprint.win.exe
> 2
> C: 16
> English_United States.1252: 16
This shows that what happens is that on Windows the LC_CTYPE=C picks
up the CP-1252 Windows code page (Latin 1), an extended ASCII
code page. And in that code page, 162 is printable.
> C: 16
>
> iswprint return value depends on LC_CTYPE, but under LC_CTYPE=C,
> iswprint (0xa2) behaves differently on Windows and Linux.
>
The difference is really in what locale/code page LC_CTYPE=C picks
up.
What does "show host-charset" show on Windows, before and after
you make GDB pick LC_CTYPE=C from the environment (with the
setlocale gnulib module)?
(Ideally, the wchar tests would actually iterate testing GDB
behaves as expected with different values of LC_CTYPE, etc. set
in the environment. With all other tests assuming ASCII as set
by default by the testsuite framework.)
--
Pedro Alves
next prev parent reply other threads:[~2014-06-12 11:36 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 12:13 Yao Qi
2014-06-04 5:32 ` [ping] " Yao Qi
2014-06-04 12:47 ` Joel Brobecker
2014-06-04 13:21 ` Yao Qi
2014-06-04 13:52 ` Joel Brobecker
2014-06-04 20:15 ` Tom Tromey
2014-06-04 20:23 ` Pedro Alves
2014-06-05 3:31 ` Yao Qi
2014-06-05 8:58 ` Pedro Alves
2014-06-05 9:58 ` Yao Qi
2014-06-05 10:12 ` Pedro Alves
2014-06-05 15:04 ` Eli Zaretskii
2014-06-09 8:37 ` Yao Qi
2014-06-09 10:11 ` Pedro Alves
2014-06-11 2:22 ` Yao Qi
2014-06-11 16:23 ` Eli Zaretskii
2014-06-12 0:48 ` Yao Qi
2014-06-12 2:47 ` Eli Zaretskii
2014-06-12 7:04 ` Yao Qi
2014-06-12 17:03 ` Eli Zaretskii
2014-06-17 1:03 ` Yao Qi
2014-06-12 11:36 ` Pedro Alves [this message]
2014-06-12 14:39 ` Yao Qi
2014-06-12 17:07 ` Eli Zaretskii
2014-06-12 17:23 ` Pedro Alves
2014-06-12 17:48 ` Eli Zaretskii
2014-06-17 3:46 ` Yao Qi
2014-06-17 10:03 ` Pedro Alves
2014-06-17 11:39 ` Yao Qi
2014-06-12 17:09 ` Eli Zaretskii
2014-06-12 17:27 ` Pedro Alves
2014-06-12 17:50 ` Eli Zaretskii
2014-06-12 18:06 ` Pedro Alves
2014-06-12 18:35 ` Eli Zaretskii
2014-06-16 13:58 ` Pedro Alves
2014-06-16 15:40 ` Eli Zaretskii
2014-06-16 16:23 ` Pedro Alves
2014-06-05 10:27 ` Pedro Alves
2014-06-05 14:47 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539990BD.9020504@redhat.com \
--to=palves@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox