Re: [ping] [PATCH] Different outputs affected by locale

[Pedro Alves <palves@redhat.com>]

On 06/05/2014 04:29 AM, Yao Qi wrote:
> On 06/05/2014 04:23 AM, Pedro Alves wrote:
>>>> I am not really a great standards lawyer but my first reaction is that
>>>> mingw's C locale is not conforming.  At least from:
>>>>
>>>>     http://pubs.opengroup.org/onlinepubs/009604499/basedefs/xbd_chap07.html
>>>>
>>>> .. it seems to me that \242 is not defined as a 'print' character in the
>>>> LC_CTYPE section.  Though I'd like to reiterate that I don't actually
>>>> trust my own reading of that text.
>> I wonder whether this is really a mingw issue, or whether this is a
>> remote host testing issue.  That is, aren't we setting LC_CTYPE
>> on the _build_ (where expect runs), not on the host (mingw, through
> 
> This is a not a mingw issue nor a remote host testing issue.  

But that's a conflicting answer.  It's a remote host testing
if this only triggers with remote host testing.

> If the
> LC_CTYPE isn't set properly on host, these tests will fail, even in the
> native testing.

Sure, but it's supposed to be set, and then tests can assume so.
If not set in some circumstance, then it's a bug in the test
infrustruture, not the test.  For native testing, those are
set by gdb.exp:gdb_init.

> 
>> ssh)?  Is LC_CTYPE really being propagated to the host?
> 
> No, setting env variables on host or target in dejagnu isn't trivial to
> me.

They need to be passed down explicitly in the ssh command line:

$ ssh localhost "FOO=1 env | grep FOO"
FOO=1

> 
>> Does testing GDB manually directly on a Windows console show the same
>> issue?
> 
> Yes, here is the output I got on Windows 7 (running gdb.exe in Windows console).
> However, I didn't investigate why 'ó' is printed.

But was that with LC_CTYPE set to C?

-- 
Pedro Alves