From: Pedro Alves <palves@redhat.com>
To: Andrew Burgess <aburgess@broadcom.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v3 3/4] Deprecate frame_stop_reason_string.
Date: Thu, 29 May 2014 09:56:00 -0000 [thread overview]
Message-ID: <53870453.6030208@redhat.com> (raw)
In-Reply-To: <53870363.20502@broadcom.com>
On 05/29/2014 10:52 AM, Andrew Burgess wrote:
> On 29/05/2014 10:00 AM, Pedro Alves wrote:
>> This still has "frame" in the name, and misses the "to". Any reason for that?
>
> No, just me being special :)
LOL!
> This function is confusingly named, the "frame_" in the name implies it
> somehow is frame dependent, when in reality the function just converts an
> 'enum unwind_stop_reason' value to a string.
Excellent and concise description/log.
>
> gdb/ChangeLog:
>
> * frame.c (frame_stop_reason_string): Rename to ...
> (unwind_stop_reason_to_string): this.
> * frame.h (frame_stop_reason_string): Rename to ...
> (unwind_stop_reason_to_string): this.
> * stack.c (frame_info): Update call to frame_stop_reason_string.
> (backtrace_command_1): Likewise.
> * guile/scm-frame.c (gdbscm_unwind_stop_reason_string): Likewise.
> * python/py-frame.c (gdbpy_frame_stop_reason_string): Likewise.
OK
Thanks,
Pedro Alves
prev parent reply other threads:[~2014-05-29 9:56 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 14:46 [RFC 0/4] Catch errors in get_prev_frame Andrew Burgess
2014-04-04 14:47 ` [RFC 1/4] New tests for backtracing with a corrupted stack Andrew Burgess
2014-04-04 14:48 ` [RFC 2/4] Remove previous frame if we error during compute_frame_id Andrew Burgess
2014-04-04 14:53 ` Andrew Burgess
2014-04-15 19:02 ` Pedro Alves
2014-04-04 14:49 ` [RFC 3/4] Deprecate frame_stop_reason_string Andrew Burgess
2014-04-04 14:55 ` Andrew Burgess
2014-04-04 14:50 ` [RFC 4/4] Add TRY_CATCH to get_prev_frame and frame specific strop strings Andrew Burgess
2014-04-15 9:11 ` [RFC 0/4] Catch errors in get_prev_frame Andrew Burgess
2014-04-17 10:15 ` [PATCH v2 1/4] New test for backtrace when the stack pointer is invalid (inaccessible) Andrew Burgess
2014-04-17 10:15 ` [PATCH v2 0/4] Catch errors in get_prev_frame Andrew Burgess
2014-04-17 10:15 ` [PATCH v2 3/4] Deprecate frame_stop_reason_string Andrew Burgess
2014-04-29 19:56 ` Pedro Alves
2014-04-30 10:46 ` Andrew Burgess
2014-04-17 10:15 ` [PATCH v2 2/4] Remove previous frame if an error occurs when computing frame id during unwind Andrew Burgess
2014-04-17 10:15 ` [PATCH v2 4/4] Add a TRY_CATCH to get_prev_frame to better handle errors " Andrew Burgess
2014-04-30 10:55 ` [PATCH v3 0/4] Catch errors in get_prev_frame Andrew Burgess
2014-04-30 10:55 ` [PATCH v3 2/4] Remove previous frame if an error occurs when computing frame id during unwind Andrew Burgess
2014-05-16 15:37 ` Pedro Alves
2014-05-28 23:16 ` Andrew Burgess
2014-04-30 10:55 ` [PATCH v3 1/4] New test for backtrace when the stack pointer is invalid (inaccessible) Andrew Burgess
2014-05-28 18:42 ` Pedro Alves
2014-04-30 10:55 ` [PATCH v3 4/4] Add a TRY_CATCH to get_prev_frame to better handle errors during unwind Andrew Burgess
2014-05-28 18:31 ` Pedro Alves
2014-05-28 23:35 ` Andrew Burgess
2014-05-29 9:41 ` Pedro Alves
2014-05-29 23:02 ` Andrew Burgess
2014-05-30 11:46 ` Pedro Alves
2014-04-30 10:55 ` [PATCH v3 3/4] Deprecate frame_stop_reason_string Andrew Burgess
2014-05-28 17:26 ` Pedro Alves
2014-05-28 23:26 ` Andrew Burgess
2014-05-29 9:00 ` Pedro Alves
2014-05-29 9:53 ` Andrew Burgess
2014-05-29 9:56 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53870453.6030208@redhat.com \
--to=palves@redhat.com \
--cc=aburgess@broadcom.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox