From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1682 invoked by alias); 29 May 2014 09:56:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1665 invoked by uid 89); 29 May 2014 09:56:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 May 2014 09:56:38 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4T9uaQS030713 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 29 May 2014 05:56:36 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s4T9uZZ4008527; Thu, 29 May 2014 05:56:36 -0400 Message-ID: <53870453.6030208@redhat.com> Date: Thu, 29 May 2014 09:56:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Andrew Burgess , gdb-patches@sourceware.org Subject: Re: [PATCH v3 3/4] Deprecate frame_stop_reason_string. References: <533EC5B7.6080600@broadcom.com> <1398855344-25278-1-git-send-email-aburgess@broadcom.com> <1398855344-25278-4-git-send-email-aburgess@broadcom.com> <53861C53.5060402@redhat.com> <538670AE.3050305@broadcom.com> <5386F73C.8000102@redhat.com> <53870363.20502@broadcom.com> In-Reply-To: <53870363.20502@broadcom.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-05/txt/msg00722.txt.bz2 On 05/29/2014 10:52 AM, Andrew Burgess wrote: > On 29/05/2014 10:00 AM, Pedro Alves wrote: >> This still has "frame" in the name, and misses the "to". Any reason for that? > > No, just me being special :) LOL! > This function is confusingly named, the "frame_" in the name implies it > somehow is frame dependent, when in reality the function just converts an > 'enum unwind_stop_reason' value to a string. Excellent and concise description/log. > > gdb/ChangeLog: > > * frame.c (frame_stop_reason_string): Rename to ... > (unwind_stop_reason_to_string): this. > * frame.h (frame_stop_reason_string): Rename to ... > (unwind_stop_reason_to_string): this. > * stack.c (frame_info): Update call to frame_stop_reason_string. > (backtrace_command_1): Likewise. > * guile/scm-frame.c (gdbscm_unwind_stop_reason_string): Likewise. > * python/py-frame.c (gdbpy_frame_stop_reason_string): Likewise. OK Thanks, Pedro Alves