Re: [PATCH] S390: Fix erroneous offset in fill_gregset

[Andreas Krebbel <krebbel@linux.vnet.ibm.com>]

On 05/13/2014 01:01 PM, Andreas Arnez wrote:
> This fixes a bug that leads to various failures when debugging a
> 31-bit inferior with a 64-bit gdb on s390x.
> 
> gdb/
> 	* s390-linux-nat.c (fill_gregset): Remove erroneous offset 4 in
> 	call to regcache_raw_collect.
> ---
>  gdb/s390-linux-nat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gdb/s390-linux-nat.c b/gdb/s390-linux-nat.c
> index 5c38952..45db7c9 100644
> --- a/gdb/s390-linux-nat.c
> +++ b/gdb/s390-linux-nat.c
> @@ -164,7 +164,7 @@ fill_gregset (const struct regcache *regcache, gregset_t *regp, int regno)
>  		  memset (p, 0, 4);
>  		  p += 4;
>  		}
> -	      regcache_raw_collect (regcache, reg, p + 4);
> +	      regcache_raw_collect (regcache, reg, p);
>  	    }
>  	}

I've committed the patch to mainline and gdb-7.7 branch. Thanks!

-Andreas-