From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27055 invoked by alias); 13 May 2014 15:07:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27037 invoked by uid 89); 13 May 2014 15:07:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e06smtp11.uk.ibm.com Received: from e06smtp11.uk.ibm.com (HELO e06smtp11.uk.ibm.com) (195.75.94.107) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 13 May 2014 15:07:15 +0000 Received: from /spool/local by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 13 May 2014 16:07:11 +0100 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 13 May 2014 16:07:07 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id BBE6817D8069 for ; Tue, 13 May 2014 16:08:14 +0100 (BST) Received: from d06av12.portsmouth.uk.ibm.com (d06av12.portsmouth.uk.ibm.com [9.149.37.247]) by b06cxnps3075.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s4DF768u66453752 for ; Tue, 13 May 2014 15:07:06 GMT Received: from d06av12.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av12.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s4DF74Sj019900 for ; Tue, 13 May 2014 09:07:05 -0600 Received: from [9.152.212.211] (dyn-9-152-212-211.boeblingen.de.ibm.com [9.152.212.211]) by d06av12.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id s4DF74XG019861; Tue, 13 May 2014 09:07:04 -0600 Message-ID: <53723517.9020808@linux.vnet.ibm.com> Date: Tue, 13 May 2014 15:07:00 -0000 From: Andreas Krebbel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Andreas Arnez , gdb-patches@sourceware.org Subject: Re: [PATCH] S390: Fix erroneous offset in fill_gregset References: <87ppji54dh.fsf@br87z6lw.de.ibm.com> In-Reply-To: <87ppji54dh.fsf@br87z6lw.de.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14051315-5024-0000-0000-000009D04EA6 X-SW-Source: 2014-05/txt/msg00160.txt.bz2 On 05/13/2014 01:01 PM, Andreas Arnez wrote: > This fixes a bug that leads to various failures when debugging a > 31-bit inferior with a 64-bit gdb on s390x. > > gdb/ > * s390-linux-nat.c (fill_gregset): Remove erroneous offset 4 in > call to regcache_raw_collect. > --- > gdb/s390-linux-nat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/s390-linux-nat.c b/gdb/s390-linux-nat.c > index 5c38952..45db7c9 100644 > --- a/gdb/s390-linux-nat.c > +++ b/gdb/s390-linux-nat.c > @@ -164,7 +164,7 @@ fill_gregset (const struct regcache *regcache, gregset_t *regp, int regno) > memset (p, 0, 4); > p += 4; > } > - regcache_raw_collect (regcache, reg, p + 4); > + regcache_raw_collect (regcache, reg, p); > } > } I've committed the patch to mainline and gdb-7.7 branch. Thanks! -Andreas-