Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: Andreas Arnez <arnez@linux.vnet.ibm.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] S390: Fix erroneous offset in fill_gregset
Date: Tue, 13 May 2014 12:47:00 -0000	[thread overview]
Message-ID: <20140513124702.GA4016@adacore.com> (raw)
In-Reply-To: <201405131224.s4DCOdT0030161@d06av02.portsmouth.uk.ibm.com>

> > gdb/
> > 	* s390-linux-nat.c (fill_gregset): Remove erroneous offset 4 in
> > 	call to regcache_raw_collect.
> 
> This is OK.
> 
> The fix probably ought to go to the 7.7 branch as well ...

We are not planning on making another release on the 7.7 branch
but it might still be good to have it there also, so no objection.
But if we backport the change, please make sure that a PR gets
created, and that an entry gets added to the 7.7 release wiki
page: https://sourceware.org/gdb/wiki/GDB_7.7_Release

I will create a "Fixes since GDB 7.7.1" section.

Thanks,
-- 
Joel


  reply	other threads:[~2014-05-13 12:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-13 11:01 Andreas Arnez
2014-05-13 12:24 ` Ulrich Weigand
2014-05-13 12:47   ` Joel Brobecker [this message]
2014-05-13 14:02     ` Andreas Arnez
2014-05-13 14:51       ` Joel Brobecker
2014-05-13 15:07 ` Andreas Krebbel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140513124702.GA4016@adacore.com \
    --to=brobecker@adacore.com \
    --cc=arnez@linux.vnet.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox