From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21467 invoked by alias); 13 May 2014 12:47:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21418 invoked by uid 89); 13 May 2014 12:47:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 13 May 2014 12:47:06 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 8EA5211616B; Tue, 13 May 2014 08:47:04 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id xSEGUt3y+K-f; Tue, 13 May 2014 08:47:04 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 5B79011617A; Tue, 13 May 2014 08:47:04 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 01883E4DB5; Tue, 13 May 2014 05:47:02 -0700 (PDT) Date: Tue, 13 May 2014 12:47:00 -0000 From: Joel Brobecker To: Ulrich Weigand Cc: Andreas Arnez , gdb-patches@sourceware.org Subject: Re: [PATCH] S390: Fix erroneous offset in fill_gregset Message-ID: <20140513124702.GA4016@adacore.com> References: <87ppji54dh.fsf@br87z6lw.de.ibm.com> <201405131224.s4DCOdT0030161@d06av02.portsmouth.uk.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201405131224.s4DCOdT0030161@d06av02.portsmouth.uk.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-05/txt/msg00157.txt.bz2 > > gdb/ > > * s390-linux-nat.c (fill_gregset): Remove erroneous offset 4 in > > call to regcache_raw_collect. > > This is OK. > > The fix probably ought to go to the 7.7 branch as well ... We are not planning on making another release on the 7.7 branch but it might still be good to have it there also, so no objection. But if we backport the change, please make sure that a PR gets created, and that an entry gets added to the 7.7 release wiki page: https://sourceware.org/gdb/wiki/GDB_7.7_Release I will create a "Fixes since GDB 7.7.1" section. Thanks, -- Joel