From: Andreas Arnez <arnez@linux.vnet.ibm.com>
To: gdb-patches@sourceware.org
Subject: [PATCH] S390: Fix erroneous offset in fill_gregset
Date: Tue, 13 May 2014 11:01:00 -0000 [thread overview]
Message-ID: <87ppji54dh.fsf@br87z6lw.de.ibm.com> (raw)
This fixes a bug that leads to various failures when debugging a
31-bit inferior with a 64-bit gdb on s390x.
gdb/
* s390-linux-nat.c (fill_gregset): Remove erroneous offset 4 in
call to regcache_raw_collect.
---
gdb/s390-linux-nat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/s390-linux-nat.c b/gdb/s390-linux-nat.c
index 5c38952..45db7c9 100644
--- a/gdb/s390-linux-nat.c
+++ b/gdb/s390-linux-nat.c
@@ -164,7 +164,7 @@ fill_gregset (const struct regcache *regcache, gregset_t *regp, int regno)
memset (p, 0, 4);
p += 4;
}
- regcache_raw_collect (regcache, reg, p + 4);
+ regcache_raw_collect (regcache, reg, p);
}
}
--
1.8.4.2
next reply other threads:[~2014-05-13 11:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 11:01 Andreas Arnez [this message]
2014-05-13 12:24 ` Ulrich Weigand
2014-05-13 12:47 ` Joel Brobecker
2014-05-13 14:02 ` Andreas Arnez
2014-05-13 14:51 ` Joel Brobecker
2014-05-13 15:07 ` Andreas Krebbel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppji54dh.fsf@br87z6lw.de.ibm.com \
--to=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox