Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Hui Zhu <hui_zhu@mentor.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
	stanshebs@earthlink.net,        gdb-patches@sourceware.org
Subject: Re: [PATCH/doc] Remove fixme of packet "k"
Date: Thu, 20 Mar 2014 13:07:00 -0000	[thread overview]
Message-ID: <532AC7A9.3030108@redhat.com> (raw)
In-Reply-To: <532A6417.1010106@mentor.com>

On 03/20/2014 03:44 AM, Hui Zhu wrote:

>   @item k
>   @cindex @samp{k} packet
> -Kill request.
> +Kill the target process or processes.
>   
> -FIXME: @emph{There is no description of how to operate when a specific
> -thread context has been selected (i.e.@: does 'k' kill only that
> -thread?)}.
> +The exact effect of this packet is not specified.  For a single-process
> +target, it will kill that process if possible.

This is looking good to me too, but I'd like to suggest further
extending it some.  As is I think this may leave bare metal stub
developers wondering what does "kill the single-process target"
means.  I'd leave the "Kill request" title unmodified.  I'd
suggest using "may" instead of "will".  I think we should mention
that even not replying an ack is OK.  So here's my suggestion:

@item k
@cindex @samp{k} packet
Kill request.

The exact effect of this packet is not specified.

For a bare-metal target, it may power cycle or reset the target
system.  For that reason, the @samp{k} packet has no reply.

For a single-process target, it may kill that process if possible.

A multiple-process target may choose to kill just one process, or all
that are under GDB's control.  For more precise control, use the vKill
packet (@pxref{vKill packet}).

If the target system immediately closes the connection in response to
@samp{k}, @value{GDBN} does not consider the lack of packet
acknowledgment to be an error, and assumes the kill was successful.

If connected using @kbd{target extended-remote}, and the target does
not close the connection in response to a kill request, @value{GDBN}
probes the target state as if a new connection was opened (pxfer to
the status/"?" packet here).

> +
> +A multiple-process target may choose to kill just one process, or all
> +that are under GDB's control.  For more precise control, use the

( Should be @value{GDBN}. )

-- 
Pedro Alves


  reply	other threads:[~2014-03-20 13:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-14  7:22 Hui Zhu
2014-03-14  8:14 ` Eli Zaretskii
2014-03-18 20:52 ` Stan Shebs
2014-03-19  8:02   ` Hui Zhu
2014-03-19 16:12     ` Eli Zaretskii
2014-03-20  3:44       ` Hui Zhu
2014-03-20 13:07         ` Pedro Alves [this message]
2014-03-20 17:30           ` Eli Zaretskii
2014-03-20 16:05         ` Eli Zaretskii
2014-03-21  8:26           ` Hui Zhu
2014-03-21  8:38             ` Eli Zaretskii
2014-03-21  9:00               ` Hui Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=532AC7A9.3030108@redhat.com \
    --to=palves@redhat.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=hui_zhu@mentor.com \
    --cc=stanshebs@earthlink.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox