Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Hui Zhu <hui_zhu@mentor.com>
To: Eli Zaretskii <eliz@gnu.org>, <stanshebs@earthlink.net>,
	Pedro Alves	<palves@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH/doc] Remove fixme of packet "k"
Date: Fri, 21 Mar 2014 08:26:00 -0000	[thread overview]
Message-ID: <532BF790.90401@mentor.com> (raw)
In-Reply-To: <83ha6s97o7.fsf@gnu.org>

On 03/21/14 00:06, Eli Zaretskii wrote:
>> Date: Thu, 20 Mar 2014 11:44:23 +0800
>> From: Hui Zhu <hui_zhu@mentor.com>
>> CC: <stanshebs@earthlink.net>, <gdb-patches@sourceware.org>
>>
>> Updated a new version according to your comments.
>
> This version is OK, thanks.
>

Make a new patch according to your comments.
Please help me review it.

Thanks,
Hui

2014-03-21  Pedro Alves  <palves@redhat.com>
	    Stan Shebs  <stan@codesourcery.com>
	    Hui Zhu  <hui@codesourcery.com>

	* gdb.texinfo (Packets): Add anchor to "? packet".
	Remove fixme and update introduction of "k packet".
	Add anchor to "vKill packet".

--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -33742,6 +33742,7 @@ The remote target both supports and has
  
  @item ?
  @cindex @samp{?} packet
+@anchor{? packet}
  Indicate the reason the target halted.  The reply is the same as for
  step and continue.  This packet has a special interpretation when the
  target is in non-stop mode; see @ref{Remote Non-Stop}.
@@ -33954,9 +33955,25 @@ step packet}.
  @cindex @samp{k} packet
  Kill request.
  
-FIXME: @emph{There is no description of how to operate when a specific
-thread context has been selected (i.e.@: does 'k' kill only that
-thread?)}.
+The exact effect of this packet is not specified.
+
+For a bare-metal target, it may power cycle or reset the target
+system.  For that reason, the @samp{k} packet has no reply.
+
+For a single-process target, it may kill that process if possible.
+
+A multiple-process target may choose to kill just one process, or all
+that are under @value{GDBN}'s control.  For more precise control, use
+the vKill packet (@pxref{vKill packet}).
+
+If the target system immediately closes the connection in response to
+@samp{k}, @value{GDBN} does not consider the lack of packet
+acknowledgment to be an error, and assumes the kill was successful.
+
+If connected using @kbd{target extended-remote}, and the target does
+not close the connection in response to a kill request, @value{GDBN}
+probes the target state as if a new connection was opened
+(@pxref{? packet}).
  
  @item m @var{addr},@var{length}
  @cindex @samp{m} packet
@@ -34258,6 +34275,7 @@ request is completed.
  
  @item vKill;@var{pid}
  @cindex @samp{vKill} packet
+@anchor{vKill packet}
  Kill the process with the specified process ID.  @var{pid} is a
  hexadecimal integer identifying the process.  This packet is used in
  preference to @samp{k} when multiprocess protocol extensions are


  reply	other threads:[~2014-03-21  8:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-14  7:22 Hui Zhu
2014-03-14  8:14 ` Eli Zaretskii
2014-03-18 20:52 ` Stan Shebs
2014-03-19  8:02   ` Hui Zhu
2014-03-19 16:12     ` Eli Zaretskii
2014-03-20  3:44       ` Hui Zhu
2014-03-20 13:07         ` Pedro Alves
2014-03-20 17:30           ` Eli Zaretskii
2014-03-20 16:05         ` Eli Zaretskii
2014-03-21  8:26           ` Hui Zhu [this message]
2014-03-21  8:38             ` Eli Zaretskii
2014-03-21  9:00               ` Hui Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=532BF790.90401@mentor.com \
    --to=hui_zhu@mentor.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=stanshebs@earthlink.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox