From: Hui Zhu <hui_zhu@mentor.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: <stanshebs@earthlink.net>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH/doc] Remove fixme of packet "k"
Date: Thu, 20 Mar 2014 03:44:00 -0000 [thread overview]
Message-ID: <532A6417.1010106@mentor.com> (raw)
In-Reply-To: <83d2hi9ngv.fsf@gnu.org>
On 03/20/14 00:12, Eli Zaretskii wrote:
>> Date: Wed, 19 Mar 2014 16:02:29 +0800
>> From: Hui Zhu <hui_zhu@mentor.com>
>> CC: Eli Zaretskii <eliz@gnu.org>
>>
>> Hi Stan,
>>
>> According to your comments. I make a new patch.
>>
>> Thanks,
>> Hui
>>
>> 2014-03-19 Stan Shebs <stan@codesourcery.com>
>> Hui Zhu <hui@codesourcery.com>
>>
>> * gdb.texinfo (k packet): Remove fixme and update introduction.
>> (vKill packet): Add anchor.
>
> Thanks. But these changes are both in the node called "Packets", not
> "k packet" or "vKill packet", so please change the text in parentheses
> to name the node (just once).
>
>> +A multiple-process target may choose to kill just one process, or all
>> +that that are under GDB's control. For more precise control, use the
> ^^^^^^^^^
> One "that" is redundant.
>
>> +vKill packet.(@pxref{vKill packet})
>
> @pxref should be before the period, like this:
>
> vKill packet (@pxref{vKill packet}).
>
> OK with those changes.
>
Updated a new version according to your comments.
Please help me review it.
Thanks,
Hui
2014-03-20 Stan Shebs <stan@codesourcery.com>
Hui Zhu <hui@codesourcery.com>
* gdb.texinfo (Packets): Remove fixme and update introduction of
"k packet". Add anchor to "vKill packet".
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -33952,11 +33952,16 @@ step packet}.
@item k
@cindex @samp{k} packet
-Kill request.
+Kill the target process or processes.
-FIXME: @emph{There is no description of how to operate when a specific
-thread context has been selected (i.e.@: does 'k' kill only that
-thread?)}.
+The exact effect of this packet is not specified. For a single-process
+target, it will kill that process if possible.
+
+A multiple-process target may choose to kill just one process, or all
+that are under GDB's control. For more precise control, use the
+vKill packet (@pxref{vKill packet}).
+
+The @samp{k} packet has no reply.
@item m @var{addr},@var{length}
@cindex @samp{m} packet
@@ -34258,6 +34263,7 @@ request is completed.
@item vKill;@var{pid}
@cindex @samp{vKill} packet
+@anchor{vKill packet}
Kill the process with the specified process ID. @var{pid} is a
hexadecimal integer identifying the process. This packet is used in
preference to @samp{k} when multiprocess protocol extensions are
next prev parent reply other threads:[~2014-03-20 3:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 7:22 Hui Zhu
2014-03-14 8:14 ` Eli Zaretskii
2014-03-18 20:52 ` Stan Shebs
2014-03-19 8:02 ` Hui Zhu
2014-03-19 16:12 ` Eli Zaretskii
2014-03-20 3:44 ` Hui Zhu [this message]
2014-03-20 13:07 ` Pedro Alves
2014-03-20 17:30 ` Eli Zaretskii
2014-03-20 16:05 ` Eli Zaretskii
2014-03-21 8:26 ` Hui Zhu
2014-03-21 8:38 ` Eli Zaretskii
2014-03-21 9:00 ` Hui Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532A6417.1010106@mentor.com \
--to=hui_zhu@mentor.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=stanshebs@earthlink.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox