From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8462 invoked by alias); 20 Mar 2014 13:07:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8453 invoked by uid 89); 20 Mar 2014 13:07:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Mar 2014 13:07:00 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s2KD5W6I006025 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 20 Mar 2014 09:06:23 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s2KAnDPb007457; Thu, 20 Mar 2014 06:49:14 -0400 Message-ID: <532AC7A9.3030108@redhat.com> Date: Thu, 20 Mar 2014 13:07:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Hui Zhu CC: Eli Zaretskii , stanshebs@earthlink.net, gdb-patches@sourceware.org Subject: Re: [PATCH/doc] Remove fixme of packet "k" References: <5322AE41.4050008@mentor.com> <5328B210.9060702@earthlink.net> <53294F15.4050503@mentor.com> <83d2hi9ngv.fsf@gnu.org> <532A6417.1010106@mentor.com> In-Reply-To: <532A6417.1010106@mentor.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-03/txt/msg00488.txt.bz2 On 03/20/2014 03:44 AM, Hui Zhu wrote: > @item k > @cindex @samp{k} packet > -Kill request. > +Kill the target process or processes. > > -FIXME: @emph{There is no description of how to operate when a specific > -thread context has been selected (i.e.@: does 'k' kill only that > -thread?)}. > +The exact effect of this packet is not specified. For a single-process > +target, it will kill that process if possible. This is looking good to me too, but I'd like to suggest further extending it some. As is I think this may leave bare metal stub developers wondering what does "kill the single-process target" means. I'd leave the "Kill request" title unmodified. I'd suggest using "may" instead of "will". I think we should mention that even not replying an ack is OK. So here's my suggestion: @item k @cindex @samp{k} packet Kill request. The exact effect of this packet is not specified. For a bare-metal target, it may power cycle or reset the target system. For that reason, the @samp{k} packet has no reply. For a single-process target, it may kill that process if possible. A multiple-process target may choose to kill just one process, or all that are under GDB's control. For more precise control, use the vKill packet (@pxref{vKill packet}). If the target system immediately closes the connection in response to @samp{k}, @value{GDBN} does not consider the lack of packet acknowledgment to be an error, and assumes the kill was successful. If connected using @kbd{target extended-remote}, and the target does not close the connection in response to a kill request, @value{GDBN} probes the target state as if a new connection was opened (pxfer to the status/"?" packet here). > + > +A multiple-process target may choose to kill just one process, or all > +that are under GDB's control. For more precise control, use the ( Should be @value{GDBN}. ) -- Pedro Alves