From: Yao Qi <yao@codesourcery.com>
To: Pedro Alves <palves@redhat.com>
Cc: Joel Brobecker <brobecker@adacore.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/4] Error on bad count number
Date: Thu, 06 Mar 2014 09:56:00 -0000 [thread overview]
Message-ID: <5318456D.3010709@codesourcery.com> (raw)
In-Reply-To: <531749BA.8050806@redhat.com>
On 03/05/2014 11:58 PM, Pedro Alves wrote:
> I had the same thought. I wondered whether 0 was meant to
> remove the enable count, but the docs don't say anything
> about it. Is there another way to disable the count, and
> bring back the disposition to enabled? If not, I wonder
> whether using 0 for that would be a good idea?
If 0 is potentially acceptable, I am fine to keep it. I'll back
to change get_number to return negative for invalid input, to
differentiate valid number zero and invalid input.
--
Yao (é½å°§)
next prev parent reply other threads:[~2014-03-06 9:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 12:49 [PATCH 0/4] Tweak get_number related code Yao Qi
2014-03-05 12:49 ` [PATCH 2/4] Error on bad count number Yao Qi
2014-03-05 14:29 ` Joel Brobecker
2014-03-05 15:59 ` Pedro Alves
2014-03-06 9:56 ` Yao Qi [this message]
2014-03-06 12:21 ` Pedro Alves
2014-03-06 13:24 ` Joel Brobecker
2014-03-07 9:40 ` Yao Qi
2014-03-07 10:53 ` Eli Zaretskii
2014-03-07 11:09 ` Yao Qi
2014-03-07 13:27 ` Pedro Alves
2014-03-07 13:50 ` Joel Brobecker
2014-03-10 2:01 ` Yao Qi
2014-03-06 13:26 ` Joel Brobecker
2014-03-05 12:49 ` [OBV PATCH 1/4] Add a newline in output messages Yao Qi
2014-03-05 14:22 ` Joel Brobecker
2014-03-06 6:45 ` Yao Qi
2014-03-05 12:49 ` [PATCH 4/4] Remove argument optional_p from get_tracepoint_by_number Yao Qi
2014-03-05 14:44 ` Joel Brobecker
2014-03-05 12:49 ` [PATCH 3/4] Handle parse number error in goto_bookmark_command Yao Qi
2014-03-05 14:38 ` Joel Brobecker
2014-03-06 7:10 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5318456D.3010709@codesourcery.com \
--to=yao@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox