From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7098 invoked by alias); 6 Mar 2014 09:56:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7086 invoked by uid 89); 6 Mar 2014 09:56:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Mar 2014 09:55:59 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1WLV1v-0002N6-3Q from Yao_Qi@mentor.com ; Thu, 06 Mar 2014 01:55:55 -0800 Received: from SVR-ORW-FEM-06.mgc.mentorg.com ([147.34.97.120]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 6 Mar 2014 01:55:54 -0800 Received: from qiyao.dyndns.org (147.34.91.1) by SVR-ORW-FEM-06.mgc.mentorg.com (147.34.97.120) with Microsoft SMTP Server id 14.2.247.3; Thu, 6 Mar 2014 01:55:50 -0800 Message-ID: <5318456D.3010709@codesourcery.com> Date: Thu, 06 Mar 2014 09:56:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Pedro Alves CC: Joel Brobecker , Subject: Re: [PATCH 2/4] Error on bad count number References: <1394023608-10761-1-git-send-email-yao@codesourcery.com> <1394023608-10761-3-git-send-email-yao@codesourcery.com> <20140305142939.GB16858@adacore.com> <531749BA.8050806@redhat.com> In-Reply-To: <531749BA.8050806@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2014-03/txt/msg00151.txt.bz2 On 03/05/2014 11:58 PM, Pedro Alves wrote: > I had the same thought. I wondered whether 0 was meant to > remove the enable count, but the docs don't say anything > about it. Is there another way to disable the count, and > bring back the disposition to enabled? If not, I wonder > whether using 0 for that would be a good idea? If 0 is potentially acceptable, I am fine to keep it. I'll back to change get_number to return negative for invalid input, to differentiate valid number zero and invalid input. -- Yao (齐尧)