Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [OBV PATCH 1/4] Add a newline in output messages
Date: Thu, 06 Mar 2014 06:45:00 -0000	[thread overview]
Message-ID: <53181900.8000304@codesourcery.com> (raw)
In-Reply-To: <20140305142236.GA16858@adacore.com>

On 03/05/2014 10:22 PM, Joel Brobecker wrote:
> Obvious indeed.
> 

Patch is pushed in.

> The error handling is a little different from the usual, where error
> would typically be used; especially since zero can be a valid number.

Yes, a message is printed out, and let the caller to decide whether to
throw an error.

> And this leads to this sort of odd behavior:
> 
>     (gdb) set $v := 1.1
>     (gdb) b a
>     Breakpoint 1 at 0x401558: file a.adb, line 3.
>     (gdb) cond $v 1 = 1
>     Convenience variable must have integer value.
>     Bad breakpoint argument: '$v 1 = 1'

Sorry, I don't find anything odd here.  Is the odd behavior to print two
lines for an invalid input?

-- 
Yao (齐尧)


  reply	other threads:[~2014-03-06  6:45 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-05 12:49 [PATCH 0/4] Tweak get_number related code Yao Qi
2014-03-05 12:49 ` [OBV PATCH 1/4] Add a newline in output messages Yao Qi
2014-03-05 14:22   ` Joel Brobecker
2014-03-06  6:45     ` Yao Qi [this message]
2014-03-05 12:49 ` [PATCH 2/4] Error on bad count number Yao Qi
2014-03-05 14:29   ` Joel Brobecker
2014-03-05 15:59     ` Pedro Alves
2014-03-06  9:56       ` Yao Qi
2014-03-06 12:21         ` Pedro Alves
2014-03-06 13:24           ` Joel Brobecker
2014-03-07  9:40           ` Yao Qi
2014-03-07 10:53             ` Eli Zaretskii
2014-03-07 11:09               ` Yao Qi
2014-03-07 13:27             ` Pedro Alves
2014-03-07 13:50               ` Joel Brobecker
2014-03-10  2:01               ` Yao Qi
2014-03-06 13:26       ` Joel Brobecker
2014-03-05 12:49 ` [PATCH 4/4] Remove argument optional_p from get_tracepoint_by_number Yao Qi
2014-03-05 14:44   ` Joel Brobecker
2014-03-05 12:49 ` [PATCH 3/4] Handle parse number error in goto_bookmark_command Yao Qi
2014-03-05 14:38   ` Joel Brobecker
2014-03-06  7:10     ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53181900.8000304@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox