From: Joel Brobecker <brobecker@adacore.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 4/4] Remove argument optional_p from get_tracepoint_by_number
Date: Wed, 05 Mar 2014 14:44:00 -0000 [thread overview]
Message-ID: <20140305144446.GD16858@adacore.com> (raw)
In-Reply-To: <1394023608-10761-5-git-send-email-yao@codesourcery.com>
> This patch is to remove parameter optional_p as it is always true,
> in order to simplify get_tracepoint_by_number.
>
> 'optional_p' was added by this change,
>
> 1999-11-18 Tom Tromey <tromey@cygnus.com>
>
> * tracepoint.h (get_tracepoint_by_number): Updated
> declaration.
> * tracepoint.c (trace_pass_command): Better error message.
> Fixed logic when `all' not specified.
> (get_tracepoint_by_number): Added `optional_p' argument. Fixed
> all callers.
>
> but after this patch,
>
> FYI: remove `static's from cli-utils.c
> https://sourceware.org/ml/gdb-patches/2011-03/msg00636.html
>
> 'optional_p' passed to get_tracepoint_by_number become always true.
FWIW - don't know much about this code, but this patch looks fine to me.
--
Joel
prev parent reply other threads:[~2014-03-05 14:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 12:49 [PATCH 0/4] Tweak get_number related code Yao Qi
2014-03-05 12:49 ` [PATCH 2/4] Error on bad count number Yao Qi
2014-03-05 14:29 ` Joel Brobecker
2014-03-05 15:59 ` Pedro Alves
2014-03-06 9:56 ` Yao Qi
2014-03-06 12:21 ` Pedro Alves
2014-03-06 13:24 ` Joel Brobecker
2014-03-07 9:40 ` Yao Qi
2014-03-07 10:53 ` Eli Zaretskii
2014-03-07 11:09 ` Yao Qi
2014-03-07 13:27 ` Pedro Alves
2014-03-07 13:50 ` Joel Brobecker
2014-03-10 2:01 ` Yao Qi
2014-03-06 13:26 ` Joel Brobecker
2014-03-05 12:49 ` [OBV PATCH 1/4] Add a newline in output messages Yao Qi
2014-03-05 14:22 ` Joel Brobecker
2014-03-06 6:45 ` Yao Qi
2014-03-05 12:49 ` [PATCH 3/4] Handle parse number error in goto_bookmark_command Yao Qi
2014-03-05 14:38 ` Joel Brobecker
2014-03-06 7:10 ` Yao Qi
2014-03-05 12:49 ` [PATCH 4/4] Remove argument optional_p from get_tracepoint_by_number Yao Qi
2014-03-05 14:44 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140305144446.GD16858@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox