From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28779 invoked by alias); 5 Mar 2014 14:44:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28768 invoked by uid 89); 5 Mar 2014 14:44:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 05 Mar 2014 14:44:47 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 0299F11635C; Wed, 5 Mar 2014 09:44:45 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id rrm1B3Y9sMPW; Wed, 5 Mar 2014 09:44:44 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C3569116351; Wed, 5 Mar 2014 09:44:44 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id EF3A1E08BE; Wed, 5 Mar 2014 06:44:46 -0800 (PST) Date: Wed, 05 Mar 2014 14:44:00 -0000 From: Joel Brobecker To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 4/4] Remove argument optional_p from get_tracepoint_by_number Message-ID: <20140305144446.GD16858@adacore.com> References: <1394023608-10761-1-git-send-email-yao@codesourcery.com> <1394023608-10761-5-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1394023608-10761-5-git-send-email-yao@codesourcery.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-03/txt/msg00121.txt.bz2 > This patch is to remove parameter optional_p as it is always true, > in order to simplify get_tracepoint_by_number. > > 'optional_p' was added by this change, > > 1999-11-18 Tom Tromey > > * tracepoint.h (get_tracepoint_by_number): Updated > declaration. > * tracepoint.c (trace_pass_command): Better error message. > Fixed logic when `all' not specified. > (get_tracepoint_by_number): Added `optional_p' argument. Fixed > all callers. > > but after this patch, > > FYI: remove `static's from cli-utils.c > https://sourceware.org/ml/gdb-patches/2011-03/msg00636.html > > 'optional_p' passed to get_tracepoint_by_number become always true. FWIW - don't know much about this code, but this patch looks fine to me. -- Joel