Re: [Windows]Fix a bug which cause GDB.exe assert when try to run the inferior

[Pedro Alves <palves@redhat.com>]

On 02/21/2014 07:03 AM, Yao Qi wrote:
> On 02/21/2014 02:11 PM, asmwarrior wrote:
>> Windows: Fix target_xfer_partial: Assertion `*xfered_len > 0' failed.
>> The failure was introduced in commit 9b409511d07fe375284701af34909fb539029caf, 2014-02-11.
>> gdb/windows-nat.c (windows_xfer_shared_libraries) : If len is 0, it should return TARGET_XFER_EOF.
> 
> The format of the changelog entry isn't correct.  On the other hand,
> changelog entry is about "what are changed", so "it should return
> TARGET_XFER_EOF" doesn't describe "what are changed" clearly.  I suggest
> something below.  Otherwise, I don't have comments.

Thanks You.  This is definitely OK.  Could you put it in?

-  return TARGET_XFER_OK;
+  return len ? TARGET_XFER_OK : TARGET_XFER_EOF;

(Please write 'len != 0' though.)

> 
> 2014-02-21  Yuanhui Zhang  <asmwarrior@gmail.com>
> 
> 	* windows-nat.c (windows_xfer_shared_libraries): Return
> 	TARGET_XFER_EOF if LEN is zero.
> 


-- 
Pedro Alves