Re: [Windows]Fix a bug which cause GDB.exe assert when try to run the inferior

[asmwarrior <asmwarrior@gmail.com>]

On 2014-2-24 14:45, Yao Qi wrote:
> > 
> > gdb:
> > 
> > 2014-02-21  Yuanhui Zhang  <asmwarrior@gmail.com>
> > 
> > 	* windows-nat.c (windows_xfer_shared_libraries): Return
> > 	TARGET_XFER_EOF if LEN is zero to fix an assert failure when
> > 	requested object is TARGET_OBJECT_LIBRARIES.
> > 
> Please update your patch to replace "len ?" with "len != 0 ?" and commit
> log we discussed here.  You can push it in.
>
> Let me know if you don't have a commit access or have trouble on
> committing, I can commit this patch for you.
Hi, Yao, thanks. I was thinking that I won't need further change, because it was a tiny patch.
Anyway, would you mind to commit for me? I don't have commit access.

 gdb/windows-nat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c
index a570a1a..b76d94d 100644
--- a/gdb/windows-nat.c
+++ b/gdb/windows-nat.c
@@ -2480,7 +2480,7 @@ windows_xfer_shared_libraries (struct target_ops *ops,
 
   obstack_free (&obstack, NULL);
   *xfered_len = (ULONGEST) len;
-  return TARGET_XFER_OK;
+  return len != 0 ? TARGET_XFER_OK : TARGET_XFER_EOF;
 }


The log message are much better than my original one.

gdb:
 
 2014-02-21  Yuanhui Zhang  <asmwarrior@gmail.com>
 
 	* windows-nat.c (windows_xfer_shared_libraries): Return
 	TARGET_XFER_EOF if LEN is zero to fix an assert failure when
 	requested object is TARGET_OBJECT_LIBRARIES.


Thanks for adjustment.

Yuanhui Zhang