From: Yao Qi <yao@codesourcery.com>
To: asmwarrior <asmwarrior@gmail.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [Windows]Fix a bug which cause GDB.exe assert when try to run the inferior
Date: Fri, 21 Feb 2014 07:05:00 -0000 [thread overview]
Message-ID: <5306FA43.1070408@codesourcery.com> (raw)
In-Reply-To: <5306EE2A.2060103@gmail.com>
On 02/21/2014 02:11 PM, asmwarrior wrote:
> Windows: Fix target_xfer_partial: Assertion `*xfered_len > 0' failed.
> The failure was introduced in commit 9b409511d07fe375284701af34909fb539029caf, 2014-02-11.
> gdb/windows-nat.c (windows_xfer_shared_libraries) : If len is 0, it should return TARGET_XFER_EOF.
The format of the changelog entry isn't correct. On the other hand,
changelog entry is about "what are changed", so "it should return
TARGET_XFER_EOF" doesn't describe "what are changed" clearly. I suggest
something below. Otherwise, I don't have comments.
gdb:
2014-02-21 Yuanhui Zhang <asmwarrior@gmail.com>
* windows-nat.c (windows_xfer_shared_libraries): Return
TARGET_XFER_EOF if LEN is zero.
--
Yao (é½å°§)
next prev parent reply other threads:[~2014-02-21 7:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 14:35 asmwarrior
2014-02-21 1:22 ` Yao Qi
2014-02-21 6:12 ` asmwarrior
2014-02-21 7:05 ` Yao Qi [this message]
2014-02-21 7:37 ` Eli Zaretskii
2014-02-21 7:59 ` Yao Qi
2014-02-21 8:07 ` Eli Zaretskii
2014-02-24 6:47 ` Yao Qi
2014-02-24 7:10 ` asmwarrior
2014-02-24 7:50 ` Yao Qi
2014-02-21 10:13 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5306FA43.1070408@codesourcery.com \
--to=yao@codesourcery.com \
--cc=asmwarrior@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox