From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26917 invoked by alias); 21 Feb 2014 07:05:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26901 invoked by uid 89); 21 Feb 2014 07:05:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Feb 2014 07:05:54 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1WGkBB-0002OV-VK from Yao_Qi@mentor.com ; Thu, 20 Feb 2014 23:05:49 -0800 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 20 Feb 2014 23:05:49 -0800 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.2.247.3; Thu, 20 Feb 2014 23:05:49 -0800 Message-ID: <5306FA43.1070408@codesourcery.com> Date: Fri, 21 Feb 2014 07:05:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: asmwarrior CC: Subject: Re: [Windows]Fix a bug which cause GDB.exe assert when try to run the inferior References: <530612A8.4000903@gmail.com> <5306A9BC.4080701@codesourcery.com> <5306EE2A.2060103@gmail.com> In-Reply-To: <5306EE2A.2060103@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2014-02/txt/msg00679.txt.bz2 On 02/21/2014 02:11 PM, asmwarrior wrote: > Windows: Fix target_xfer_partial: Assertion `*xfered_len > 0' failed. > The failure was introduced in commit 9b409511d07fe375284701af34909fb539029caf, 2014-02-11. > gdb/windows-nat.c (windows_xfer_shared_libraries) : If len is 0, it should return TARGET_XFER_EOF. The format of the changelog entry isn't correct. On the other hand, changelog entry is about "what are changed", so "it should return TARGET_XFER_EOF" doesn't describe "what are changed" clearly. I suggest something below. Otherwise, I don't have comments. gdb: 2014-02-21 Yuanhui Zhang * windows-nat.c (windows_xfer_shared_libraries): Return TARGET_XFER_EOF if LEN is zero. -- Yao (齐尧)