From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18650 invoked by alias); 21 Feb 2014 10:13:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18636 invoked by uid 89); 21 Feb 2014 10:13:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Feb 2014 10:13:53 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1LADniG015386 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 21 Feb 2014 05:13:49 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s1LADmre001266; Fri, 21 Feb 2014 05:13:48 -0500 Message-ID: <530726DB.2000905@redhat.com> Date: Fri, 21 Feb 2014 10:13:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Yao Qi CC: asmwarrior , gdb-patches@sourceware.org Subject: Re: [Windows]Fix a bug which cause GDB.exe assert when try to run the inferior References: <530612A8.4000903@gmail.com> <5306A9BC.4080701@codesourcery.com> <5306EE2A.2060103@gmail.com> <5306FA43.1070408@codesourcery.com> In-Reply-To: <5306FA43.1070408@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-02/txt/msg00686.txt.bz2 On 02/21/2014 07:03 AM, Yao Qi wrote: > On 02/21/2014 02:11 PM, asmwarrior wrote: >> Windows: Fix target_xfer_partial: Assertion `*xfered_len > 0' failed. >> The failure was introduced in commit 9b409511d07fe375284701af34909fb539029caf, 2014-02-11. >> gdb/windows-nat.c (windows_xfer_shared_libraries) : If len is 0, it should return TARGET_XFER_EOF. > > The format of the changelog entry isn't correct. On the other hand, > changelog entry is about "what are changed", so "it should return > TARGET_XFER_EOF" doesn't describe "what are changed" clearly. I suggest > something below. Otherwise, I don't have comments. Thanks You. This is definitely OK. Could you put it in? - return TARGET_XFER_OK; + return len ? TARGET_XFER_OK : TARGET_XFER_EOF; (Please write 'len != 0' though.) > > 2014-02-21 Yuanhui Zhang > > * windows-nat.c (windows_xfer_shared_libraries): Return > TARGET_XFER_EOF if LEN is zero. > -- Pedro Alves