From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Yao Qi <yao@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [RFC 1/2] link gdbserver against libiberty
Date: Fri, 07 Feb 2014 16:32:00 -0000 [thread overview]
Message-ID: <52F50A87.6000907@redhat.com> (raw)
In-Reply-To: <87y51n0yh4.fsf@fleche.redhat.com>
On 02/07/2014 02:49 PM, Tom Tromey wrote:
> Yao> ... and I don't understand why do we remove AR and AR_FLAGS from
> Yao> FLAGS_TO_PASS.
>
> I don't remember any more, either.
> I restored them and rebuilt and it all worked fine.
> I did discover that my earlier patch had broken "make install"; fixed in
> this version.
This looks good to me. Thanks for doing this.
> -SUBDIRS = $(GNULIB_BUILDDIR)
> +SUBDIRS = $(GNULIB_BUILDDIR) $(LIBIBERTY_BUILDDIR)
> CLEANDIRS = $(SUBDIRS)
> +INSTALLDIRS = $(GNULIB_BUILDDIR)
I understand making sure we don't try to install anything from
libiberty. Preexisting to this patch, but I wonder why we even
run make install in gnulib. Seems that like with libiberty,
we wouldn't ever want to install anything built in gnulib
subdir.
--
Pedro Alves
next prev parent reply other threads:[~2014-02-07 16:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 18:49 [RFC 0/2] let gdbserver use libiberty Tom Tromey
2014-01-20 18:49 ` [RFC 1/2] link gdbserver against libiberty Tom Tromey
2014-01-21 1:49 ` Yao Qi
2014-01-21 2:33 ` Tom Tromey
2014-02-07 14:49 ` Tom Tromey
2014-02-07 16:32 ` Pedro Alves [this message]
2014-02-07 21:00 ` Tom Tromey
2014-02-10 13:27 ` Pedro Alves
2014-02-12 16:44 ` Tom Tromey
2014-02-12 16:49 ` Pedro Alves
2014-02-08 2:36 ` Yao Qi
2014-01-21 2:03 ` Yao Qi
2014-01-20 18:49 ` [RFC 2/2] delete gdbserver's freeargv Tom Tromey
2014-02-07 16:35 ` Pedro Alves
2014-01-20 18:54 ` [RFC 0/2] let gdbserver use libiberty Tom Tromey
2014-06-12 20:37 ` Tom Tromey
2014-06-16 13:26 ` James Greenhalgh
2014-06-18 12:27 ` Marcus Shawcroft
2014-06-19 14:48 ` Tom Tromey
2014-06-20 10:52 ` Pedro Alves
2014-06-20 12:01 ` Gary Benson
2014-06-20 14:16 ` Tom Tromey
2014-06-20 14:44 ` [COMMITTED PATCH] Fix mingw32 build on x86-64 RHEL 6.5 Gary Benson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F50A87.6000907@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox