Re: [RFC 0/2] let gdbserver use libiberty

[James Greenhalgh <james.greenhalgh@arm.com>]

On Thu, Jun 12, 2014 at 09:37:19PM +0100, Tom Tromey wrote:
> >>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:
> 
> Tom> This series changes gdbserver to build its own copy of libiberty
> Tom> (using ACX_CONFIGURE_DIR) and then link against it.  I've needed this
> Tom> at least once (for a cloexec patch) and I've seen other situations
> Tom> where it would have been useful.
> 
> This series slipped through the cracks somehow.  I'm going to push it
> now.  I believe I addressed all the review comments upthread.  I rebased
> it and rebuilt it on x86-64 Fedora 20; let me know if you encounter any
> problems.

Hi Tom,

This seems to cause issues when building gdbserver as part of a larger
Canadian Cross ARM/AArch64 build. ar ends up confused having seemingly lost
the expected flags:

----

ar  ./libiberty.a \
	  ./regex.o ./cplus-dem.o ./cp-demangle.o ./md5.o ./sha1.o ./alloca.o ./argv.o ./choose-temp.o ./concat.o ./cp-demint.o ./crc32.o ./dwarfnames.o ./dyn-string.o ./fdmatch.o ./fibheap.o ./filename_cmp.o ./floatformat.o ./fnmatch.o ./fopen_unlocked.o ./getopt.o ./getopt1.o ./getpwd.o ./getruntime.o ./hashtab.o ./hex.o ./lbasename.o ./lrealpath.o ./make-relative-prefix.o ./make-temp-file.o ./objalloc.o ./obstack.o ./partition.o ./pexecute.o ./physmem.o ./pex-common.o ./pex-one.o ./pex-unix.o ./safe-ctype.o ./simple-object.o ./simple-object-coff.o ./simple-object-elf.o ./simple-object-mach-o.o ./simple-object-xcoff.o ./sort.o ./spaces.o ./splay-tree.o ./stack-limit.o ./strerror.o ./strsignal.o ./timeval-utils.o ./unlink-if-ordinary.o ./xatexit.o ./xexit.o ./xmalloc.o ./xmemdup.o ./xstrdup.o ./xstrerror.o ./xstrndup.o  ./setproctitle.o

ar: illegal option -- .
Usage: ar [emulation options] [-]{dmpqrstx}[abcfilNoPsSuvV] [member-name] [count] archive-file file...
       ar -M [<mri-script]

----

The small patch below (from your initial patch series) gets the build
going again, but looking back at the discussion, I see this was
controversial and was dropped before the final commit.

My knowledge of the build system is minimal, but I'm happy to test any
proposed patches.

Thanks,
James Greenhalgh

---

diff --git a/gdb/gdbserver/Makefile.in b/gdb/gdbserver/Makefile.in
index cbf36ab..86c404d 100644
--- a/gdb/gdbserver/Makefile.in
+++ b/gdb/gdbserver/Makefile.in
@@ -217,8 +217,6 @@ FLAGS_TO_PASS = \
 	"includedir=$(includedir)" \
 	"against=$(against)" \
 	"DESTDIR=$(DESTDIR)" \
-	"AR=$(AR)" \
-	"AR_FLAGS=$(AR_FLAGS)" \
 	"CC=$(CC)" \
 	"CFLAGS=$(CFLAGS)" \
 	"CXX=$(CXX)" \