From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: Yao Qi <yao@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [RFC 1/2] link gdbserver against libiberty
Date: Fri, 07 Feb 2014 21:00:00 -0000 [thread overview]
Message-ID: <87bnyi1vw5.fsf@fleche.redhat.com> (raw)
In-Reply-To: <52F50A87.6000907@redhat.com> (Pedro Alves's message of "Fri, 07 Feb 2014 16:32:07 +0000")
>> -SUBDIRS = $(GNULIB_BUILDDIR)
>> +SUBDIRS = $(GNULIB_BUILDDIR) $(LIBIBERTY_BUILDDIR)
>> CLEANDIRS = $(SUBDIRS)
>> +INSTALLDIRS = $(GNULIB_BUILDDIR)
Pedro> I understand making sure we don't try to install anything from
Pedro> libiberty. Preexisting to this patch, but I wonder why we even
Pedro> run make install in gnulib. Seems that like with libiberty,
Pedro> we wouldn't ever want to install anything built in gnulib
Pedro> subdir.
On the one hand it is odd; but on the other it can be argued for from a
black-box perspective. The reason I skipped this for libiberty is that
gdb uses its own "install-only" target when entering subdirs; but this
is neither GNU nor generally used in the rest of the tree. So, it
caused installation to fail.
It's possible to fix this another way, say entering libiberty and using
the "install" target there. But it seems not worth the effort to me;
first because we don't want to install anything in libiberty (unless one
highly values the black box approach, which I do not); and second
because eventually I will be moving all this stuff to the top-level
anyway.
Tom
next prev parent reply other threads:[~2014-02-07 21:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 18:49 [RFC 0/2] let gdbserver use libiberty Tom Tromey
2014-01-20 18:49 ` [RFC 2/2] delete gdbserver's freeargv Tom Tromey
2014-02-07 16:35 ` Pedro Alves
2014-01-20 18:49 ` [RFC 1/2] link gdbserver against libiberty Tom Tromey
2014-01-21 1:49 ` Yao Qi
2014-01-21 2:33 ` Tom Tromey
2014-02-07 14:49 ` Tom Tromey
2014-02-07 16:32 ` Pedro Alves
2014-02-07 21:00 ` Tom Tromey [this message]
2014-02-10 13:27 ` Pedro Alves
2014-02-12 16:44 ` Tom Tromey
2014-02-12 16:49 ` Pedro Alves
2014-02-08 2:36 ` Yao Qi
2014-01-21 2:03 ` Yao Qi
2014-01-20 18:54 ` [RFC 0/2] let gdbserver use libiberty Tom Tromey
2014-06-12 20:37 ` Tom Tromey
2014-06-16 13:26 ` James Greenhalgh
2014-06-18 12:27 ` Marcus Shawcroft
2014-06-19 14:48 ` Tom Tromey
2014-06-20 10:52 ` Pedro Alves
2014-06-20 12:01 ` Gary Benson
2014-06-20 14:16 ` Tom Tromey
2014-06-20 14:44 ` [COMMITTED PATCH] Fix mingw32 build on x86-64 RHEL 6.5 Gary Benson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bnyi1vw5.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox