From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20687 invoked by alias); 7 Feb 2014 16:32:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20676 invoked by uid 89); 7 Feb 2014 16:32:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 07 Feb 2014 16:32:14 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s17GWA22014244 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 7 Feb 2014 11:32:10 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s17GW8Mv010380; Fri, 7 Feb 2014 11:32:08 -0500 Message-ID: <52F50A87.6000907@redhat.com> Date: Fri, 07 Feb 2014 16:32:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: Yao Qi , gdb-patches@sourceware.org Subject: Re: [RFC 1/2] link gdbserver against libiberty References: <1390243792-31176-1-git-send-email-tromey@redhat.com> <1390243792-31176-2-git-send-email-tromey@redhat.com> <52DDD1BA.7050202@codesourcery.com> <87y51n0yh4.fsf@fleche.redhat.com> In-Reply-To: <87y51n0yh4.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-02/txt/msg00213.txt.bz2 On 02/07/2014 02:49 PM, Tom Tromey wrote: > Yao> ... and I don't understand why do we remove AR and AR_FLAGS from > Yao> FLAGS_TO_PASS. > > I don't remember any more, either. > I restored them and rebuilt and it all worked fine. > I did discover that my earlier patch had broken "make install"; fixed in > this version. This looks good to me. Thanks for doing this. > -SUBDIRS = $(GNULIB_BUILDDIR) > +SUBDIRS = $(GNULIB_BUILDDIR) $(LIBIBERTY_BUILDDIR) > CLEANDIRS = $(SUBDIRS) > +INSTALLDIRS = $(GNULIB_BUILDDIR) I understand making sure we don't try to install anything from libiberty. Preexisting to this patch, but I wonder why we even run make install in gnulib. Seems that like with libiberty, we wouldn't ever want to install anything built in gnulib subdir. -- Pedro Alves