From: Yao Qi <yao@codesourcery.com>
To: David Edelsohn <dje.gcc@gmail.com>
Cc: GDB Patches <gdb-patches@sourceware.org>,
Joel Brobecker <brobecker@adacore.com>,
Ulrich Weigand <uweigand@de.ibm.com>
Subject: Re: [PATCH] Cast to uintptr_t when calling ptrace32 on aix
Date: Mon, 06 Jan 2014 01:14:00 -0000 [thread overview]
Message-ID: <52CA02FE.6060804@codesourcery.com> (raw)
In-Reply-To: <CAGWvnykbAX1aY+qeXT0GR6rBevK6ao2Us9nt4UmwUvtdzkbK1A@mail.gmail.com>
On 01/06/2014 12:22 AM, David Edelsohn wrote:
> Thanks for uncovering this and creating a patch. Any patch like this
> should be regression tested.
>
OK, I'll test it on gcc111.
> I thought that these issues had been addressed in Joel's patches from
> last August.
>
> https://sourceware.org/ml/gdb-patches/2013-08/msg00657.html
>
> Why do we need to go through this delicate dance in slightly different
> ways in multiple files?
IMO, we do it in the same way, convert address to uintptr_t first and
then to "addr_ptr" (long long). Joel's is the implicit conversion and
mine is an explicit one.
--
Yao (é½å°§)
next prev parent reply other threads:[~2014-01-06 1:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-05 16:22 David Edelsohn
2014-01-06 1:14 ` Yao Qi [this message]
2014-01-06 1:21 ` David Edelsohn
2014-01-06 16:48 ` Tom Tromey
-- strict thread matches above, loose matches on Subject: below --
2014-01-04 7:50 Yao Qi
2014-01-06 15:57 ` Joel Brobecker
2014-01-06 16:11 ` Joel Brobecker
2014-01-07 10:32 ` Joel Brobecker
2014-01-07 13:07 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CA02FE.6060804@codesourcery.com \
--to=yao@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=dje.gcc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox