Re: [PATCH] Cast to uintptr_t when calling ptrace32 on aix

[David Edelsohn <dje.gcc@gmail.com>]

I meant it would be nice to encapsulate this in one file instead of
defining ptrace32, ptrace64, ptracex, etc. multiple times in multiple
files. It appears that you are performing the same cast as Joel, so it
should be correct. It would be nice to use a consistent syntax. But it
would be even nicer to do this only once.

Thanks David


On Sun, Jan 5, 2014 at 8:12 PM, Yao Qi <yao@codesourcery.com> wrote:
> On 01/06/2014 12:22 AM, David Edelsohn wrote:
>> Thanks for uncovering this and creating a patch. Any patch like this
>> should be regression tested.
>>
>
> OK, I'll test it on gcc111.
>
>> I thought that these issues had been addressed in Joel's patches from
>> last August.
>>
>> https://sourceware.org/ml/gdb-patches/2013-08/msg00657.html
>>
>> Why do we need to go through this delicate dance in slightly different
>> ways in multiple files?
>
> IMO, we do it in the same way, convert address to uintptr_t first and
> then to "addr_ptr" (long long).  Joel's is the implicit conversion and
> mine is an explicit one.
>
> --
> Yao (齐尧)