From: Joel Brobecker <brobecker@adacore.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Cast to uintptr_t when calling ptrace32 on aix
Date: Mon, 06 Jan 2014 16:11:00 -0000 [thread overview]
Message-ID: <20140106161121.GC3802@adacore.com> (raw)
In-Reply-To: <20140106155717.GB3802@adacore.com>
> > 2014-01-04 Yao Qi <yao@codesourcery.com>
> >
> > * aix-thread.c (pdc_read_regs): Cast parameter to uintptr_t
> > first.
> > (pdc_write_regs): Likewise.
> > (fetch_regs_kernel_thread): Likewise.
> > (store_regs_kernel_thread): Likewise.
>
> Thank you, Yao. I tested your patch with AdaCore's gdb testsuite,
> and found no regression.
>
> Some of the lines are now exceeding the hard limit (80 characters),
> and need to be folded. Apart from David's suggestion, which we can
> look at independently, the patch looks OK to me.
Actually, re-reading David's comments, I agree with him. Can we try
using a consistent approach? That would be an easy adaptation of your
patch, or mine, whichever you'd prefer. I don't really see the real
need for the second cast, so I'd lean towards adapting yours.
--
Joel
next prev parent reply other threads:[~2014-01-06 16:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-04 7:50 Yao Qi
2014-01-06 15:57 ` Joel Brobecker
2014-01-06 16:11 ` Joel Brobecker [this message]
2014-01-07 10:32 ` Joel Brobecker
2014-01-07 13:07 ` Yao Qi
2014-01-05 16:22 David Edelsohn
2014-01-06 1:14 ` Yao Qi
2014-01-06 1:21 ` David Edelsohn
2014-01-06 16:48 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140106161121.GC3802@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox