From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13238 invoked by alias); 6 Jan 2014 16:11:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13229 invoked by uid 89); 6 Jan 2014 16:11:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 06 Jan 2014 16:11:27 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 58AAD116601; Mon, 6 Jan 2014 11:11:25 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 24GPprXdwQJH; Mon, 6 Jan 2014 11:11:25 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id F1E0D116478; Mon, 6 Jan 2014 11:11:24 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id ABE08E0833; Mon, 6 Jan 2014 20:11:21 +0400 (RET) Date: Mon, 06 Jan 2014 16:11:00 -0000 From: Joel Brobecker To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Cast to uintptr_t when calling ptrace32 on aix Message-ID: <20140106161121.GC3802@adacore.com> References: <1388821701-8011-1-git-send-email-yao@codesourcery.com> <20140106155717.GB3802@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140106155717.GB3802@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-01/txt/msg00059.txt.bz2 > > 2014-01-04 Yao Qi > > > > * aix-thread.c (pdc_read_regs): Cast parameter to uintptr_t > > first. > > (pdc_write_regs): Likewise. > > (fetch_regs_kernel_thread): Likewise. > > (store_regs_kernel_thread): Likewise. > > Thank you, Yao. I tested your patch with AdaCore's gdb testsuite, > and found no regression. > > Some of the lines are now exceeding the hard limit (80 characters), > and need to be folded. Apart from David's suggestion, which we can > look at independently, the patch looks OK to me. Actually, re-reading David's comments, I agree with him. Can we try using a consistent approach? That would be an easy adaptation of your patch, or mine, whichever you'd prefer. I don't really see the real need for the second cast, so I'd lean towards adapting yours. -- Joel