From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21748 invoked by alias); 6 Jan 2014 01:14:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21734 invoked by uid 89); 6 Jan 2014 01:14:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.5 required=5.0 tests=AWL,BAYES_00,GARBLED_BODY autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 Jan 2014 01:14:19 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1Vzyli-0007cq-TY from Yao_Qi@mentor.com ; Sun, 05 Jan 2014 17:14:14 -0800 Received: from SVR-ORW-FEM-05.mgc.mentorg.com ([147.34.97.43]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Sun, 5 Jan 2014 17:14:14 -0800 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.2.247.3; Sun, 5 Jan 2014 17:13:17 -0800 Message-ID: <52CA02FE.6060804@codesourcery.com> Date: Mon, 06 Jan 2014 01:14:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: David Edelsohn CC: GDB Patches , Joel Brobecker , Ulrich Weigand Subject: Re: [PATCH] Cast to uintptr_t when calling ptrace32 on aix References: In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00038.txt.bz2 On 01/06/2014 12:22 AM, David Edelsohn wrote: > Thanks for uncovering this and creating a patch. Any patch like this > should be regression tested. > OK, I'll test it on gcc111. > I thought that these issues had been addressed in Joel's patches from > last August. > > https://sourceware.org/ml/gdb-patches/2013-08/msg00657.html > > Why do we need to go through this delicate dance in slightly different > ways in multiple files? IMO, we do it in the same way, convert address to uintptr_t first and then to "addr_ptr" (long long). Joel's is the implicit conversion and mine is an explicit one. -- Yao (齐尧)