Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: Pedro Alves <palves@redhat.com>
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/3] skip_prolgoue (amd64)
Date: Thu, 05 Dec 2013 14:08:00 -0000	[thread overview]
Message-ID: <52A0888B.5000309@codesourcery.com> (raw)
In-Reply-To: <52A06AC1.1030209@redhat.com>

On 12/05/2013 08:00 PM, Pedro Alves wrote:
> I think we can.  My view here is that handling an event
> is a quick and short lived operation.  GDB bursts a few reads
> in sequence, and then moves on to the next event.  In that
> scenario, you get as much stale results with or without a cache.

I disagree.  Results may be staled with cache, but results may be 
different, not staled, without cache.  They are different because they 
are red on different times, but all of them are valid.  It is a snapshot 
of a piece of memory on a certain moment.

> IOW, even without the cache, running threads can change memory as
> GDB reads it, and so the chances of hitting stale data with or
> without a cache are practically the same.  OTOH, distinct target
> events (and commands, etc.) can trigger quite apart (time-wise),
> and that break the odd balance -- not flushing the cache
> between events increases the changes of hitting stale data,

I suspect you meant "chances" instead of "changes".

> compared to not having a cache.

Flushing the cache decreases likelihood of getting staled data, but
can't completely remove it.  I am fine to use cache in non-stop mode, as 
it helps performance, so we have to compromise.

>
>> >Beside the predicate "is any thread running", another is "no thread is
>> >resumed since last flushing".  Cache should be flushed when either is
>> >true.
> Not sure I understood that.

I meant, even "none of threads is running now", we may have to flush 
cache if "they were resumed" (and all stopped now).

-- 
Yao (齐尧)


  reply	other threads:[~2013-12-05 14:08 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-29 14:27 [PATCH 0/3] Use target_read_code in skip_prologue Yao Qi
2013-11-29 14:27 ` [PATCH 2/3] skip_prolgoue (amd64) Yao Qi
2013-11-29 14:38   ` Mark Kettenis
2013-11-29 18:55     ` Mark Kettenis
2013-11-30  3:40       ` Yao Qi
2013-11-30 12:01         ` Pedro Alves
2013-12-02  7:34           ` Yao Qi
2013-12-03 18:28             ` Pedro Alves
2013-12-04  2:34             ` Yao Qi
2013-12-04 12:08               ` Pedro Alves
2013-12-04 15:38                 ` Tom Tromey
2013-12-04 18:31                   ` Doug Evans
2013-12-05 11:31                   ` Pedro Alves
2013-12-05  1:21                 ` Yao Qi
2013-12-05 12:08                   ` Pedro Alves
2013-12-05 14:08                     ` Yao Qi [this message]
2013-12-05 14:37                       ` Pedro Alves
2013-12-08  8:01                 ` Yao Qi
2013-12-08  8:26                   ` Doug Evans
2013-12-09  1:45                     ` Yao Qi
2013-12-09 11:32                       ` Pedro Alves
2013-12-09 11:53                   ` Pedro Alves
2013-12-09 13:03                     ` Yao Qi
2013-12-09 13:13                       ` Pedro Alves
2013-12-09 13:58                         ` Yao Qi
2013-12-09 15:34                           ` Pedro Alves
2013-12-10  0:57                             ` Yao Qi
2013-12-10 10:23                               ` Pedro Alves
2013-12-10 12:02                                 ` Yao Qi
2013-12-04 17:42             ` Doug Evans
2013-12-04 18:00             ` Doug Evans
2013-12-04 17:54           ` Doug Evans
2013-12-05  1:39             ` Yao Qi
2013-12-05 11:47             ` Pedro Alves
2013-11-29 14:36 ` [PATCH 1/3] Use target_read_code in skip_prologue (i386) Yao Qi
2013-11-30 11:43   ` Pedro Alves
2013-11-29 14:38 ` [PATCH 3/3] Perf test case: skip-prologue Yao Qi
2013-12-03  7:34   ` Yao Qi
2013-12-10 12:45     ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52A0888B.5000309@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox