From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/3] skip_prolgoue (amd64)
Date: Tue, 03 Dec 2013 18:28:00 -0000 [thread overview]
Message-ID: <529E22B3.6070203@redhat.com> (raw)
In-Reply-To: <529C37A2.9000207@codesourcery.com>
On 12/02/2013 07:32 AM, Yao Qi wrote:
> On 11/30/2013 06:11 PM, Pedro Alves wrote:
>> I'm thinking we might need to flush the dcache before handling each
>> event, like we already invalidate the overlay cache (see
>> "overlay_cache_invalid = 1" in infrun.c) ?
>
> I don't know why overlay cache is flushed in each event. Doing some
> archaeology doesn't give me any clue. I doubt that the overly may
> change between any two events. It (flushing overlay cache) looks not
> necessary to me, at least, when overlay events breakpoint is enabled.
Even with overlay events breakpoint enabled, I'd think we'd want to
be careful to not hit the previous cache even _while_ handling
the overlay breakpoint event. Also, with multi-threading, the
overlay breakpoint event may trigger at the same time as some
other event in another thread, and we may end up handling
the other event first.
--
Pedro Alves
next prev parent reply other threads:[~2013-12-03 18:28 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-29 14:27 [PATCH 0/3] Use target_read_code in skip_prologue Yao Qi
2013-11-29 14:27 ` [PATCH 2/3] skip_prolgoue (amd64) Yao Qi
2013-11-29 14:38 ` Mark Kettenis
2013-11-29 18:55 ` Mark Kettenis
2013-11-30 3:40 ` Yao Qi
2013-11-30 12:01 ` Pedro Alves
2013-12-02 7:34 ` Yao Qi
2013-12-03 18:28 ` Pedro Alves [this message]
2013-12-04 2:34 ` Yao Qi
2013-12-04 12:08 ` Pedro Alves
2013-12-04 15:38 ` Tom Tromey
2013-12-04 18:31 ` Doug Evans
2013-12-05 11:31 ` Pedro Alves
2013-12-05 1:21 ` Yao Qi
2013-12-05 12:08 ` Pedro Alves
2013-12-05 14:08 ` Yao Qi
2013-12-05 14:37 ` Pedro Alves
2013-12-08 8:01 ` Yao Qi
2013-12-08 8:26 ` Doug Evans
2013-12-09 1:45 ` Yao Qi
2013-12-09 11:32 ` Pedro Alves
2013-12-09 11:53 ` Pedro Alves
2013-12-09 13:03 ` Yao Qi
2013-12-09 13:13 ` Pedro Alves
2013-12-09 13:58 ` Yao Qi
2013-12-09 15:34 ` Pedro Alves
2013-12-10 0:57 ` Yao Qi
2013-12-10 10:23 ` Pedro Alves
2013-12-10 12:02 ` Yao Qi
2013-12-04 17:42 ` Doug Evans
2013-12-04 18:00 ` Doug Evans
2013-12-04 17:54 ` Doug Evans
2013-12-05 1:39 ` Yao Qi
2013-12-05 11:47 ` Pedro Alves
2013-11-29 14:36 ` [PATCH 1/3] Use target_read_code in skip_prologue (i386) Yao Qi
2013-11-30 11:43 ` Pedro Alves
2013-11-29 14:38 ` [PATCH 3/3] Perf test case: skip-prologue Yao Qi
2013-12-03 7:34 ` Yao Qi
2013-12-10 12:45 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529E22B3.6070203@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox