From: Luis Machado <lgustavo@codesourcery.com>
To: "'gdb-patches@sourceware.org'" <gdb-patches@sourceware.org>
Subject: Re: checked in: Re: RFC: solib.c:solib_map_sections so->so_name clobbering
Date: Sat, 26 Oct 2013 02:30:00 -0000 [thread overview]
Message-ID: <526B2936.3080208@codesourcery.com> (raw)
In-Reply-To: 20130411012015.GF24389@adacore.com
Hi,
It looks like this commit introduced a small regression for MI and
shared libraries, and the testsuite does not cover this case.
Suppose we have GDB running on a host and a stub/gdbserver running on a
separate remote target. Suppose shared libraries (for symbols) on the
target are located in a different path compared to the host, say,
<host_path> and <target_path>.
During debugging, eventually the shared libraries will be loaded and we
used to see a shared library load notification like the following:
=library-loaded,id="<target_path>/libhello.so",target-name="<target_path>/libhello.so",host-name="<host_path>/libhello.so",symbols-loaded="0",thread-group="i1"
After this commit, this is what we see:
=library-loaded,id="<target_path>/libhello.so",target-name="<target_path>/libhello.so",host-name="<target_path>/libhello.so",symbols-loaded="0",thread-group="i1"
So it looks like we've lost information about the shared library's path
on the host, which may not be a big deal for CLI GDB, but may confuse
consumers of MI output.
I gave this a quick thought, but reverting the change seemed like the
most obvious solution.
But since this change affects darwin, maybe Joel has a different idea?
next reply other threads:[~2013-10-26 2:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-26 2:30 Luis Machado [this message]
2013-10-26 2:35 ` Luis Machado
2013-10-26 4:29 ` Joel Brobecker
2013-10-27 2:46 ` Luis Machado
2013-10-28 11:39 ` Joel Brobecker
2013-12-04 16:59 ` Joel Brobecker
2013-12-15 10:02 ` Joel Brobecker
-- strict thread matches above, loose matches on Subject: below --
2012-07-18 19:34 [PATCH 02/10] clean up allocation of bfd filenames Tom Tromey
2013-03-28 12:29 ` RFC: solib.c:solib_map_sections so->so_name clobbering (was: [PATCH 02/10] clean up allocation of bfd filenames) Joel Brobecker
2013-03-28 19:12 ` RFC: solib.c:solib_map_sections so->so_name clobbering Tom Tromey
2013-03-29 1:59 ` Joel Brobecker
2013-04-11 4:03 ` checked in: " Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526B2936.3080208@codesourcery.com \
--to=lgustavo@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox