From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: solib.c:solib_map_sections so->so_name clobbering
Date: Thu, 28 Mar 2013 19:12:00 -0000 [thread overview]
Message-ID: <87li97cz5j.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20130328011107.GA17105@adacore.com> (Joel Brobecker's message of "Wed, 27 Mar 2013 18:11:07 -0700")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> With that in mind, I think the overwriting of the so_name might not
Joel> be needed or make much sense anymore. Removing it should fix the
Joel> regression on Darwin, and also help in the case of my work with the
Joel> solib-aix patch [1].
Joel> What do you (or others!) think? I am happy to test and submit a proper
Joel> patch.
It sounds reasonable to me.
I'm sorry about the mess here.
Joel> We wouldn't be able to use a patch like this on the 7.6 branch,
Joel> so for Darwin, I'd restore the xstrdup below - it would be a memory
Joel> leak, but better to have a leak than not having the shared library name,
Joel> IMO.
You can make it not leak by using bfd_alloc.
Tom
next prev parent reply other threads:[~2013-03-28 15:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 19:34 [PATCH 02/10] clean up allocation of bfd filenames Tom Tromey
2012-07-19 18:52 ` Jan Kratochvil
2012-07-19 20:59 ` Tom Tromey
2012-07-20 16:30 ` Tom Tromey
2012-07-20 18:07 ` Jan Kratochvil
2013-03-28 12:29 ` RFC: solib.c:solib_map_sections so->so_name clobbering (was: [PATCH 02/10] clean up allocation of bfd filenames) Joel Brobecker
2013-03-28 19:12 ` Tom Tromey [this message]
2013-03-29 1:59 ` RFC: solib.c:solib_map_sections so->so_name clobbering Joel Brobecker
2013-03-29 7:43 ` darwin: fix SO name in "info sharedlibrary" (was: "RFC: solib.c:solib_map_sections so->so_name clobbering") Joel Brobecker
2013-04-09 2:17 ` darwin: fix SO name in "info sharedlibrary" Tom Tromey
2013-04-11 5:40 ` checked in: " Joel Brobecker
2013-04-11 4:03 ` checked in: Re: RFC: solib.c:solib_map_sections so->so_name clobbering Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87li97cz5j.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox