From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 02/10] clean up allocation of bfd filenames
Date: Fri, 20 Jul 2012 16:30:00 -0000 [thread overview]
Message-ID: <87629iwg2p.fsf@fleche.redhat.com> (raw)
In-Reply-To: <87394nxya6.fsf@fleche.redhat.com> (Tom Tromey's message of "Thu, 19 Jul 2012 14:59:29 -0600")
Jan> Would not it be worth propose this bfd filename memory storage
Jan> globally in bfd/ ?
Tom> I went back and forth on this.
Tom> I think it would probably be better in general, but I wasn't too
Tom> enthused about auditing a lot of code that I don't know well to make the
Tom> change globally.
I remembered the argument that made me decide to do it in gdb.
BFD made a choice, long ago, to have clients manage the memory for the
filename. My patch just changes one client to handle it in a uniform
way. Changing other clients, or changing the library itself, might make
sense -- but it might not, and I don't really know anything about some
of these clients, like 'ld'. So I figured it was ok to leave things in
this state.
Tom
next prev parent reply other threads:[~2012-07-20 16:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 19:34 Tom Tromey
2012-07-19 18:52 ` Jan Kratochvil
2012-07-19 20:59 ` Tom Tromey
2012-07-20 16:30 ` Tom Tromey [this message]
2012-07-20 18:07 ` Jan Kratochvil
2013-03-28 12:29 ` RFC: solib.c:solib_map_sections so->so_name clobbering (was: [PATCH 02/10] clean up allocation of bfd filenames) Joel Brobecker
2013-03-28 19:12 ` RFC: solib.c:solib_map_sections so->so_name clobbering Tom Tromey
2013-03-29 1:59 ` Joel Brobecker
2013-03-29 7:43 ` darwin: fix SO name in "info sharedlibrary" (was: "RFC: solib.c:solib_map_sections so->so_name clobbering") Joel Brobecker
2013-04-09 2:17 ` darwin: fix SO name in "info sharedlibrary" Tom Tromey
2013-04-11 5:40 ` checked in: " Joel Brobecker
2013-04-11 4:03 ` checked in: Re: RFC: solib.c:solib_map_sections so->so_name clobbering Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87629iwg2p.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox