From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4248 invoked by alias); 28 Mar 2013 15:39:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4100 invoked by uid 89); 28 Mar 2013 15:38:56 -0000 X-Spam-SWARE-Status: No, score=-7.1 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 28 Mar 2013 15:38:52 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2SFcnYa014012 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 28 Mar 2013 11:38:49 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r2SFcmAY023910 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 28 Mar 2013 11:38:49 -0400 From: Tom Tromey To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: RFC: solib.c:solib_map_sections so->so_name clobbering References: <87r4s83lu5.fsf@fleche.redhat.com> <20130328011107.GA17105@adacore.com> Date: Thu, 28 Mar 2013 19:12:00 -0000 In-Reply-To: <20130328011107.GA17105@adacore.com> (Joel Brobecker's message of "Wed, 27 Mar 2013 18:11:07 -0700") Message-ID: <87li97cz5j.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-03/txt/msg01064.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> With that in mind, I think the overwriting of the so_name might not Joel> be needed or make much sense anymore. Removing it should fix the Joel> regression on Darwin, and also help in the case of my work with the Joel> solib-aix patch [1]. Joel> What do you (or others!) think? I am happy to test and submit a proper Joel> patch. It sounds reasonable to me. I'm sorry about the mess here. Joel> We wouldn't be able to use a patch like this on the 7.6 branch, Joel> so for Darwin, I'd restore the xstrdup below - it would be a memory Joel> leak, but better to have a leak than not having the shared library name, Joel> IMO. You can make it not leak by using bfd_alloc. Tom