From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15481 invoked by alias); 26 Oct 2013 02:30:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15467 invoked by uid 89); 26 Oct 2013 02:30:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 26 Oct 2013 02:30:40 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1VZte9-0002ps-HY from Luis_Gustavo@mentor.com for gdb-patches@sourceware.org; Fri, 25 Oct 2013 19:30:37 -0700 Received: from NA1-MAIL.mgc.mentorg.com ([147.34.98.181]) by svr-orw-fem-01.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Fri, 25 Oct 2013 19:30:37 -0700 Received: from [172.30.2.185] ([172.30.2.185]) by NA1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 25 Oct 2013 19:30:36 -0700 Message-ID: <526B2936.3080208@codesourcery.com> Date: Sat, 26 Oct 2013 02:30:00 -0000 From: Luis Machado Reply-To: lgustavo@codesourcery.com User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: "'gdb-patches@sourceware.org'" Subject: Re: checked in: Re: RFC: solib.c:solib_map_sections so->so_name clobbering In-Reply-To: 20130411012015.GF24389@adacore.com Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00835.txt.bz2 Hi, It looks like this commit introduced a small regression for MI and shared libraries, and the testsuite does not cover this case. Suppose we have GDB running on a host and a stub/gdbserver running on a separate remote target. Suppose shared libraries (for symbols) on the target are located in a different path compared to the host, say, and . During debugging, eventually the shared libraries will be loaded and we used to see a shared library load notification like the following: =library-loaded,id="/libhello.so",target-name="/libhello.so",host-name="/libhello.so",symbols-loaded="0",thread-group="i1" After this commit, this is what we see: =library-loaded,id="/libhello.so",target-name="/libhello.so",host-name="/libhello.so",symbols-loaded="0",thread-group="i1" So it looks like we've lost information about the shared library's path on the host, which may not be a big deal for CLI GDB, but may confuse consumers of MI output. I gave this a quick thought, but reverting the change seemed like the most obvious solution. But since this change affects darwin, maybe Joel has a different idea?