From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/6] Move notif_queue to remote_state
Date: Mon, 30 Sep 2013 17:08:00 -0000 [thread overview]
Message-ID: <5249B011.1080207@redhat.com> (raw)
In-Reply-To: <5249293D.8050700@codesourcery.com>
On 09/30/2013 08:33 AM, Yao Qi wrote:
> -/* Process notifications one by one. EXCEPT is not expected in
> - the queue. */
> +/* Process notifications in in STATE's notification queue one by one.
double "in"
> + EXCEPT is not expected in the queue. */
> void
> -remote_notif_process (struct notif_client *except)
> +remote_notif_process (struct remote_notif_state *state,
> + struct notif_client *except)
> {
> +DECLARE_QUEUE_P (notif_client_p);
> +
> +/* State on remote async notification. */
> +
> +struct remote_notif_state
> +{
> + /* Notification queue. */
> + QUEUE(notif_client_p) *notif_queue;
> +
> + /* Asynchronous signal handle registered as event loop source for when
> + the remote sent us a notification. The registered callback
> + will do a ACK sequence to pull the rest of the events out of
> + the remote side into our event queue. */
> +
> + struct async_event_handler *remote_async_get_pending_events_token;
Inconsistent "empty line between describing comment and field".
> -static void
> -notif_xfree (struct notif_client *notif)
...
> - if (notif->pending_event != NULL
> - && notif->pending_event->dtr != NULL)
> - notif->pending_event->dtr (notif->pending_event);
Hmm, it's not clear to me from reading the patch where is
pending_event released after this patch. Could you help
me understand that?
--
Pedro Alves
next prev parent reply other threads:[~2013-09-30 17:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 1:56 [PATCH 0/6 V5] MI notification on trace started/stopped Yao Qi
2013-08-19 1:56 ` [PATCH 2/6] Add annex in an async remote notification Yao Qi
2013-09-26 18:43 ` Pedro Alves
2013-09-27 1:44 ` Yao Qi
2013-10-18 1:05 ` Yao Qi
2013-08-19 1:56 ` [PATCH 5/6] MI notification on trace started/stopped:basic Yao Qi
2013-08-19 1:56 ` [PATCH 3/6] Query supported notifications by qSupported Yao Qi
2013-08-19 1:56 ` [PATCH 6/6] MI notification on trace stop: triggered by remote Yao Qi
2013-08-19 1:56 ` [PATCH 1/6] Move notif_queue to remote_state Yao Qi
2013-09-25 16:12 ` Pedro Alves
2013-09-30 7:34 ` Yao Qi
2013-09-30 7:58 ` Move pending_event to remote_notif_state ([PATCH 1/6] Move notif_queue to remote_state) Yao Qi
2013-09-30 19:34 ` Pedro Alves
2013-10-04 7:42 ` Yao Qi
2013-09-30 17:08 ` Pedro Alves [this message]
2013-10-01 14:08 ` [PATCH 1/6] Move notif_queue to remote_state Yao Qi
2013-10-02 1:54 ` Yao Qi
2013-10-02 10:48 ` Pedro Alves
2013-10-04 7:36 ` Yao Qi
2013-08-19 1:56 ` [PATCH 4/6] async remote notification 'Trace' Yao Qi
2013-09-02 0:14 ` [PATCH 0/6 V5] MI notification on trace started/stopped Yao Qi
2013-09-18 13:24 ` [ping 2]: " Yao Qi
2013-09-18 13:25 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5249B011.1080207@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox