From: Yao Qi <yao@codesourcery.com>
To: Pedro Alves <palves@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/6] Add annex in an async remote notification.
Date: Fri, 27 Sep 2013 01:44:00 -0000 [thread overview]
Message-ID: <5244E2F6.6050306@codesourcery.com> (raw)
In-Reply-To: <52448041.3070703@redhat.com>
On 09/27/2013 02:43 AM, Pedro Alves wrote:
> This mechanism adds a bunch of new code. I've read the series and the
> descriptions a few times, and I still haven't managed to find where
> the rationale behind these annexes is (or figure it out myself).:-(
>
> _Why_ are they necessary? What problem do they solve, that simply
> calling these notifications "Trace-status", "Point-modified", and
> later other new notifications "Trace-whatever-else", "Point-whatnot",
> etc. wouldn't solve? If it's just neat grouping, than it doesn't
> look like worthwhile.
>
> The only thing that comes to mind is ordering -- that is, all
> event with the same base notification handled on a FIFO basis,
> even if they have different annexes. But that doesn't look like
> to be the reason -- given that the other annex
> hinted -- Point:modified -- belongs to a different notification.
The ordering is the reason we add annex. As you said, events
with the same basic notification are handled in a FIFO manner. Events
with Point:created, Point:modified, and Point:deleted should be
processed in a FIFO order, while Trace:status and Trace:foo should be
processed in FIFO too. When this series was written, 2013 Jan, hui was
proposing "target-defined breakpoint", which requires some asnyc
notifications on breakpoints, so we added annex in V3.
[PATCH 1/5] Add annex in a async remote notification.
https://sourceware.org/ml/gdb-patches/2013-01/msg00506.html
Nowadays, we have few notifications (Stop and Trace) and each of them
are not related. As more notification added, we'll need annex in the
infrastructure, IMO.
A lot of code is added for annex, but the code is more modulized. It is
flexible to add a new notification or add a new annex for an
existing notification.
--
Yao (é½å°§)
next prev parent reply other threads:[~2013-09-27 1:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 1:56 [PATCH 0/6 V5] MI notification on trace started/stopped Yao Qi
2013-08-19 1:56 ` [PATCH 6/6] MI notification on trace stop: triggered by remote Yao Qi
2013-08-19 1:56 ` [PATCH 3/6] Query supported notifications by qSupported Yao Qi
2013-08-19 1:56 ` [PATCH 4/6] async remote notification 'Trace' Yao Qi
2013-08-19 1:56 ` [PATCH 1/6] Move notif_queue to remote_state Yao Qi
2013-09-25 16:12 ` Pedro Alves
2013-09-30 7:34 ` Yao Qi
2013-09-30 7:58 ` Move pending_event to remote_notif_state ([PATCH 1/6] Move notif_queue to remote_state) Yao Qi
2013-09-30 19:34 ` Pedro Alves
2013-10-04 7:42 ` Yao Qi
2013-09-30 17:08 ` [PATCH 1/6] Move notif_queue to remote_state Pedro Alves
2013-10-01 14:08 ` Yao Qi
2013-10-02 1:54 ` Yao Qi
2013-10-02 10:48 ` Pedro Alves
2013-10-04 7:36 ` Yao Qi
2013-08-19 1:56 ` [PATCH 2/6] Add annex in an async remote notification Yao Qi
2013-09-26 18:43 ` Pedro Alves
2013-09-27 1:44 ` Yao Qi [this message]
2013-10-18 1:05 ` Yao Qi
2013-08-19 1:56 ` [PATCH 5/6] MI notification on trace started/stopped:basic Yao Qi
2013-09-02 0:14 ` [PATCH 0/6 V5] MI notification on trace started/stopped Yao Qi
2013-09-18 13:24 ` [ping 2]: " Yao Qi
2013-09-18 13:25 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5244E2F6.6050306@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox