From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 902 invoked by alias); 30 Sep 2013 17:08:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 880 invoked by uid 89); 30 Sep 2013 17:08:41 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 30 Sep 2013 17:08:40 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8UH8ZR2031585 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 30 Sep 2013 13:08:36 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r8UH8Yet002444; Mon, 30 Sep 2013 13:08:34 -0400 Message-ID: <5249B011.1080207@redhat.com> Date: Mon, 30 Sep 2013 17:08:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 1/6] Move notif_queue to remote_state References: <1376877311-4135-1-git-send-email-yao@codesourcery.com> <1376877311-4135-2-git-send-email-yao@codesourcery.com> <52430B69.4090301@redhat.com> <5249293D.8050700@codesourcery.com> In-Reply-To: <5249293D.8050700@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-09/txt/msg01012.txt.bz2 On 09/30/2013 08:33 AM, Yao Qi wrote: > -/* Process notifications one by one. EXCEPT is not expected in > - the queue. */ > +/* Process notifications in in STATE's notification queue one by one. double "in" > + EXCEPT is not expected in the queue. */ > void > -remote_notif_process (struct notif_client *except) > +remote_notif_process (struct remote_notif_state *state, > + struct notif_client *except) > { > +DECLARE_QUEUE_P (notif_client_p); > + > +/* State on remote async notification. */ > + > +struct remote_notif_state > +{ > + /* Notification queue. */ > + QUEUE(notif_client_p) *notif_queue; > + > + /* Asynchronous signal handle registered as event loop source for when > + the remote sent us a notification. The registered callback > + will do a ACK sequence to pull the rest of the events out of > + the remote side into our event queue. */ > + > + struct async_event_handler *remote_async_get_pending_events_token; Inconsistent "empty line between describing comment and field". > -static void > -notif_xfree (struct notif_client *notif) ... > - if (notif->pending_event != NULL > - && notif->pending_event->dtr != NULL) > - notif->pending_event->dtr (notif->pending_event); Hmm, it's not clear to me from reading the patch where is pending_event released after this patch. Could you help me understand that? -- Pedro Alves