From: Pedro Alves <palves@redhat.com>
To: Tristan Gingold <gingold@adacore.com>
Cc: "gdb-patches@sourceware.org ml" <gdb-patches@sourceware.org>,
Joel Brobecker <brobecker@adacore.com>,
Roland Schwingel <roland.schwingel@onevision.de>
Subject: Re: [PATCH v3] Windows x64 SEH unwinder
Date: Tue, 27 Aug 2013 17:45:00 -0000 [thread overview]
Message-ID: <521CE5C1.2030700@redhat.com> (raw)
In-Reply-To: <9FD66EEA-C685-4F32-8F91-F9E0FF6AAAEE@adacore.com>
Hi there,
On 08/23/2013 07:53 AM, Tristan Gingold wrote:
>
> On Aug 22, 2013, at 6:15 PM, Pedro Alves <palves@redhat.com> wrote:
>> I'm guessing that using SEH if available would
>> be better over dwarf2 (though I don't know for sure).
>
> Why ?
No particular reason -- I guess I got confused by earlier
discussions in v1/v2, and I understood it as such.
> I think that both unwinders should be correct. One might
> be faster than the other, but I don't know which.
Okay.
>
>> And, this version is then a compromise. Right?
>
> The only compromise is when there are no unwind infos. Previously
> a default unwinder based on heuristic was used (doesn't work well,
> particularly for MS dll). With the patch, they are considered as
> leaf functions by the SEH unwinder.
Okay.
FAOD, the patch is fine with me.
--
Pedro Alves
next prev parent reply other threads:[~2013-08-27 17:45 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-09 10:53 Add Windows x64 SEH unwinder (take 2) Joel Brobecker
2013-01-09 10:53 ` [RFA/commit+doco 2/2] Windows x64 SEH unwinder Joel Brobecker
2013-01-09 15:52 ` Pedro Alves
2013-01-09 16:28 ` Tristan Gingold
2013-01-09 17:10 ` Pedro Alves
2013-01-09 17:53 ` Tom Tromey
2013-01-09 19:11 ` Pedro Alves
2013-01-09 20:07 ` Tristan Gingold
2013-01-10 16:24 ` Pedro Alves
2013-01-11 8:04 ` Tristan Gingold
2013-07-08 10:55 ` [RFA] Windows x64 SEH unwinder (v2) Tristan Gingold
2013-07-26 15:22 ` Pedro Alves
2013-08-19 13:59 ` Tristan Gingold
2013-08-19 14:13 ` Pedro Alves
2013-08-22 9:33 ` [PATCH v3] Windows x64 SEH unwinder Tristan Gingold
2013-08-22 15:10 ` Eli Zaretskii
2013-08-22 15:26 ` Pedro Alves
2013-08-22 15:41 ` Tristan Gingold
2013-08-22 16:15 ` Pedro Alves
2013-08-23 6:54 ` Tristan Gingold
2013-08-27 17:45 ` Pedro Alves [this message]
2013-09-02 9:28 ` Tristan Gingold
2013-01-09 16:06 ` [RFA/commit+doco 2/2] " Eli Zaretskii
2013-01-09 16:29 ` Tristan Gingold
2013-01-09 10:53 ` [RFA/commit+NEWS 1/2] Add command set/show debug unwind Joel Brobecker
2013-01-09 12:41 ` Jan Kratochvil
2013-01-09 18:40 ` Joel Brobecker
2013-01-09 15:14 ` Tom Tromey
2013-01-09 16:01 ` Eli Zaretskii
2013-01-09 11:05 ` Add Windows x64 SEH unwinder (take 2) Pedro Alves
2013-01-09 11:11 ` Joel Brobecker
2013-08-22 12:07 [PATCH v3] Windows x64 SEH unwinder Roland Schwingel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521CE5C1.2030700@redhat.com \
--to=palves@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=gingold@adacore.com \
--cc=roland.schwingel@onevision.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox